Issue 12297010: - Split the implementation of NoSuchMethodError in preparation for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12297010: - Split the implementation of NoSuchMethodError in preparation for (Closed)

Created:
7 years, 10 months ago by Ivan Posva

Modified:
7 years, 10 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Split the implementation of NoSuchMethodError in preparation for better error messages from the VM. Committed: https://code.google.com/p/dart/source/detail?r=18614

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -43 lines)			Patch
M	runtime/lib/errors_patch.dart	View	1 chunk	+55 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/core_patch.dart	View	1 chunk	+47 lines, -0 lines	0 comments	Download
M	sdk/lib/core/errors.dart	View	1 chunk	+1 line, -43 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. Let us know what kind of improvements you come up with and we'll see ...

7 years, 10 months ago (2013-02-18 06:30:52 UTC) #2

Ivan Posva

7 years, 10 months ago (2013-02-18 07:04:06 UTC) #3

Message was sent while issue was closed.

On 2013/02/18 06:30:52, kasperl wrote:
> LGTM. Let us know what kind of improvements you come up with and we'll see if
we
> can improve it in dart2js too.

The first step will be about getting better error messages from the compiler for
NoSuchMethodErrors which are inserted into the code statically as the eventual
error condition is determined at compile time.

I'll cc you on the VM change.

-Ivan

Expand Messages | Collapse Messages