Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12295008: [Android] Enable CLD and translate (Closed)

Created:
7 years, 10 months ago by Miguel Garcia
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable CLD for Android and register the translate manager on the renderer BUG=149349 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Miguel Garcia
Darin: I need an owner's approval for build/common.gypi since the build/ directory does not seem ...
7 years, 10 months ago (2013-02-18 10:28:40 UTC) #1
darin (slow to review)
LGTM for common.gypi
7 years, 10 months ago (2013-02-19 06:31:01 UTC) #2
Jay Civelli
lgtm
7 years, 10 months ago (2013-02-19 17:00:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/12295008/1
7 years, 10 months ago (2013-02-20 09:31:19 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 13:54:14 UTC) #5
Message was sent while issue was closed. 
Change committed as 183513

Powered by Google App Engine
This is Rietveld 408576698