DelegatedFrameHost should handle satisfied sequences in frame metadata.

DelegatedFrameHost should handle satisfied sequences in frame metadata.

When a RenderWidgetHostViewAura is acting as a guest view, it may need
to process satisifed sequences, received in the frame metadata, for its
embedder. This CL adds the satsfied sequence list to the data passed to
SwapDelegatedFrame() and includes it in the metadata subsequently passed
to SubmitFrame().

The CL also adds a dedicated BrowserPlugin satisfy callback in
ChildFrameCompositingHelper, just to make sure that these callbacks are
routed properly.

BUG=503594
Committed: https://crrev.com/1e720d2f120ba0cf3293a642285af3d9d987f28e
Cr-Commit-Position: refs/heads/master@{#338696}

[wjmaclean, 2015-07-13 13:21:04]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-13 13:21:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229413003/1

[wjmaclean, 2015-07-13 13:23:03]

wjmaclean@chromium.org changed reviewers:
+ jochen@chromium.org

[wjmaclean, 2015-07-13 13:23:04]

Small-ish CL ... ptal?

[commit-bot: I haz the power, 2015-07-13 13:41:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 13:41:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

(exceeded global retry quota)

[wjmaclean, 2015-07-13 14:02:40]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-13 14:02:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229413003/20001

[commit-bot: I haz the power, 2015-07-13 14:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 14:21:09]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

(exceeded global retry quota)

[wjmaclean, 2015-07-13 15:32:46]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-13 15:33:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229413003/40001

[commit-bot: I haz the power, 2015-07-13 18:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 18:23:39]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2015-07-14 12:28:37]

wjmaclean@chromium.org changed reviewers:
+ jbauman@chromium.org

[jochen (gone - plz use gerrit), 2015-07-14 14:33:00]

https://codereview.chromium.org/1229413003/diff/40001/content/browser/composi...
File content/browser/compositor/delegated_frame_host.h (right):

https://codereview.chromium.org/1229413003/diff/40001/content/browser/composi...
content/browser/compositor/delegated_frame_host.h:127: std::vector<uint32_t>
satifies_sequences);
why is this pass by value? I'd either expect a const ref or a pointer

[wjmaclean, 2015-07-14 14:58:01]

Updated, ptal?

https://codereview.chromium.org/1229413003/diff/40001/content/browser/composi...
File content/browser/compositor/delegated_frame_host.h (right):

https://codereview.chromium.org/1229413003/diff/40001/content/browser/composi...
content/browser/compositor/delegated_frame_host.h:127: std::vector<uint32_t>
satifies_sequences);
On 2015/07/14 14:33:00, jochen wrote:
> why is this pass by value? I'd either expect a const ref or a pointer

My bad ... the function modifies the vector (via swap), so it should have been a
pointer. Since we generally have few, if any, sequences in the vector copying
isn't *totally* awful, but I think we want to be clear that SwapDelegatedFrame
is 'consuming' the sequences in this vector.

Fixed.

[jochen (gone - plz use gerrit), 2015-07-14 14:59:50]

lgtm with comment

https://codereview.chromium.org/1229413003/diff/60001/content/browser/composi...
File content/browser/compositor/delegated_frame_host.h (right):

https://codereview.chromium.org/1229413003/diff/60001/content/browser/composi...
content/browser/compositor/delegated_frame_host.h:127: std::vector<uint32_t>*
satifies_sequences);
can you please add an comment that states that satisfies_sequences will be
cleared by this call?

[wjmaclean, 2015-07-14 15:04:24]

On 2015/07/14 14:59:50, jochen wrote:
> lgtm with comment
> 
>
https://codereview.chromium.org/1229413003/diff/60001/content/browser/composi...
> File content/browser/compositor/delegated_frame_host.h (right):
> 
>
https://codereview.chromium.org/1229413003/diff/60001/content/browser/composi...
> content/browser/compositor/delegated_frame_host.h:127: std::vector<uint32_t>*
> satifies_sequences);
> can you please add an comment that states that satisfies_sequences will be
> cleared by this call?

Will do!

[wjmaclean, 2015-07-14 15:08:29]

https://codereview.chromium.org/1229413003/diff/60001/content/browser/composi...
File content/browser/compositor/delegated_frame_host.h (right):

https://codereview.chromium.org/1229413003/diff/60001/content/browser/composi...
content/browser/compositor/delegated_frame_host.h:127: std::vector<uint32_t>*
satifies_sequences);
On 2015/07/14 14:59:50, jochen wrote:
> can you please add an comment that states that satisfies_sequences will be
> cleared by this call?

Done.

[wjmaclean, 2015-07-14 15:08:39]

The CQ bit was checked by wjmaclean@chromium.org

[wjmaclean, 2015-07-14 15:08:40]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1229413003/#ps80001
(title: "Add comment stating that |satifies_sequences| is cleared on call to
SwapDelegatedFrame.")

[commit-bot: I haz the power, 2015-07-14 15:09:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229413003/80001

[commit-bot: I haz the power, 2015-07-14 16:10:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-14 16:10:59]

Patchset 5 (id:??) landed as
https://crrev.com/1e720d2f120ba0cf3293a642285af3d9d987f28e
Cr-Commit-Position: refs/heads/master@{#338696}