Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 12294009: Serial bitrate fix for linux (Closed)

Created:
7 years, 10 months ago by x-warrior
Modified:
7 years, 10 months ago
Reviewers:
miket_OOO, ctndesigner
CC:
chromium-reviews, Aaron Boodman, sail+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fixing serial baut/bit rate definition on PostOpen for Linux. By "STANDARD" POSIX defines that B9600, B38400 defined types should be used. Linux define it on /usr/include/rpcsvc/rex.h and it uses numeric sequence increment to enumeration, Mac OS X define it as the same number for example #define B38400 38400. So If you're trying to connect on Linux using a bautrate 38400 for example, the cfsetispeed was called using the 38400 int value, that works for MAC but not for Linux. Code was changed to met the STANDART Bxxxxxx. Mac OS definition: http://developer.apple.com/library/ios/#documentation/System/Conceptual/ManPages_iPhoneOS/man3/cfsetispeed.3.html Contributed by matheusbrat@gmail.com BUG found by cTn / Shadow6363 @ freenode - Thanks! BUG=176439, 176711 TEST=Try to open a connection with different bitrates on Linux and see that is working. More information about how to reproduce it on Bug report. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183543

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M AUTHORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_connection_posix.cc View 1 2 3 1 chunk +82 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
x-warrior
Fix for Serial set bitrate option for Linux. The older code doesn't use defined constants ...
7 years, 10 months ago (2013-02-18 06:36:05 UTC) #1
x-warrior
Checking the termios.h file ( https://code.google.com/p/chromium/codesearch#chromium/usr/include/bits/termios.h ) I see a lot of speed definitions over ...
7 years, 10 months ago (2013-02-18 06:58:14 UTC) #2
x-warrior
- Sorry about all the mails. I'm new to the platform and getting used to ...
7 years, 10 months ago (2013-02-18 07:04:25 UTC) #3
cTn
On 2013/02/18 06:58:14, matheusbrat wrote: > Checking the termios.h file ( > https://code.google.com/p/chromium/codesearch#chromium/usr/include/bits/termios.h > ) ...
7 years, 10 months ago (2013-02-18 07:05:32 UTC) #4
miket_OOO
LGTM. Thanks!
7 years, 10 months ago (2013-02-19 17:51:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matheusbrat@gmail.com/12294009/5
7 years, 10 months ago (2013-02-19 18:12:08 UTC) #6
x-warrior
Hey guys, I'm checking the errors: The ios_rel_device doesn't seem related with my changes at ...
7 years, 10 months ago (2013-02-19 20:55:37 UTC) #7
miket_OOO
> The ios_rel_device doesn't seem related with my changes at all. Could it be > ...
7 years, 10 months ago (2013-02-19 20:59:37 UTC) #8
x-warrior
On 2013/02/19 20:59:37, miket wrote: > > The ios_rel_device doesn't seem related with my changes ...
7 years, 10 months ago (2013-02-19 21:12:50 UTC) #9
miket_OOO
> Is this correct? Yeah, except I'd put the comment near the #else, because that's ...
7 years, 10 months ago (2013-02-19 21:35:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matheusbrat@gmail.com/12294009/7002
7 years, 10 months ago (2013-02-19 23:49:58 UTC) #11
cTn
whats with the failed win_rel, that can't be related to this commit
7 years, 10 months ago (2013-02-20 01:36:25 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=113428
7 years, 10 months ago (2013-02-20 09:45:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matheusbrat@gmail.com/12294009/17001
7 years, 10 months ago (2013-02-20 13:19:42 UTC) #14
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 15:29:14 UTC) #15
Message was sent while issue was closed.
Change committed as 183543

Powered by Google App Engine
This is Rietveld 408576698