VM: Share some stub code between isolates.

runtime/vm/stub_code_ia32.cc

Index: runtime/vm/stub_code_ia32.cc
diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc
index 6da8c44a6b439f2ab33da733a3dfe88789919898..462df4fcda1c42c9be6c728a0f5464163bc3266c 100644
--- a/runtime/vm/stub_code_ia32.cc
+++ b/runtime/vm/stub_code_ia32.cc
@@ -1344,9 +1344,9 @@ void StubCode::GenerateNArgsCheckInlineCacheStub(
   Label stepping, done_stepping;
   if (FLAG_support_debugger && !optimized) {
     __ Comment("Check single stepping");
-    uword single_step_address = reinterpret_cast<uword>(Isolate::Current()) +
-        Isolate::single_step_offset();
-    __ cmpb(Address::Absolute(single_step_address), Immediate(0));
+    __ LoadIsolate(EAX);
+    __ movzxb(EAX, Address(EAX, Isolate::single_step_offset()));
+    __ testl(EAX, EAX);

[rmacnak, 2015/07/10 20:37:38]

why not 

    __ LoadIsolate(EAX);
    __ cmpb(Address(EAX, Isolate::single_step_offset()), Immediate(0));

like x64?

[Florian Schneider, 2015/07/13 07:53:41]

done.

     __ j(NOT_EQUAL, &stepping);
     __ Bind(&done_stepping);
   }
@@ -1646,9 +1646,9 @@ void StubCode::GenerateZeroArgsUnoptimizedStaticCallStub(Assembler* assembler) {
   // Check single stepping.
   Label stepping, done_stepping;
   if (FLAG_support_debugger) {
-    uword single_step_address = reinterpret_cast<uword>(Isolate::Current()) +
-        Isolate::single_step_offset();
-    __ cmpb(Address::Absolute(single_step_address), Immediate(0));
+    __ LoadIsolate(EAX);
+    __ movzxb(EAX, Address(EAX, Isolate::single_step_offset()));
+    __ testl(EAX, EAX);
     __ j(NOT_EQUAL, &stepping, Assembler::kNearJump);
     __ Bind(&done_stepping);
   }