Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 12289003: When signing in to chrome explicitly (first run, ntp, wrench) don't wait for (Closed)

Created:
7 years, 10 months ago by Roger Tawa OOO till Jul 10th
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

When signing in to chrome explicitly (first run, ntp, wrench) don't wait for signin manager and/or sync to finish before navigating away from the blank page. The user will see the NTP much sooner, with the welcome bubble. In the case of a subsequent error, the NTP is reloaded to show the error message in the bubble. BUG=176190 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183575

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Tim, Can you take a look? Thanks.
7 years, 10 months ago (2013-02-15 19:12:34 UTC) #1
tim (not reviewing)
lgtm
7 years, 10 months ago (2013-02-15 22:13:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/12289003/4001
7 years, 10 months ago (2013-02-19 18:04:32 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-20 09:59:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/12289003/12001
7 years, 10 months ago (2013-02-20 16:16:05 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 18:48:10 UTC) #6
Message was sent while issue was closed.
Change committed as 183575

Powered by Google App Engine
This is Rietveld 408576698