Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 12288013: Add PNaCl PPAPI browser tests via pre-translation. (Closed)

Created:
7 years, 10 months ago by jvoung (off chromium)
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add PNaCl PPAPI browser tests via pre-translation. Helps test that the shim and the compiler work together correctly. At this moment, this does not use the in-browser translator, since the ppapi browser test nexe is large and the translation cache does not get shared between invocations. See comments in bug 2484 about this. BUG= https://code.google.com/p/nativeclient/issues/detail?id=2484 TEST= browser_tests --gtest_filter=*PNaCl* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186787

Patch Set 1 #

Patch Set 2 : add other variants #

Patch Set 3 : Rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -4 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 3 16 chunks +141 lines, -3 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 1 2 3 3 chunks +9 lines, -0 lines 0 comments Download
M ppapi/ppapi_untrusted.gyp View 3 chunks +64 lines, -1 line 0 comments Download
M ppapi/tests/test_case.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jvoung (off chromium)
7 years, 10 months ago (2013-02-16 00:47:23 UTC) #1
Derek Schuff
LGTM
7 years, 10 months ago (2013-02-19 17:54:57 UTC) #2
jvoung (off chromium)
On 2013/02/19 17:54:57, Derek Schuff wrote: > LGTM Hi dmichael (listed you for OWNERS review ...
7 years, 10 months ago (2013-02-20 19:50:25 UTC) #3
dmichael (off chromium)
On 2013/02/20 19:50:25, jvoung (cr) wrote: > On 2013/02/19 17:54:57, Derek Schuff wrote: > > ...
7 years, 10 months ago (2013-02-20 20:47:09 UTC) #4
jvoung (off chromium)
On 2013/02/20 20:47:09, dmichael wrote: > On 2013/02/20 19:50:25, jvoung (cr) wrote: > > On ...
7 years, 10 months ago (2013-02-20 21:59:43 UTC) #5
jvoung (off chromium)
On 2013/02/20 21:59:43, jvoung (cr) wrote: > On 2013/02/20 20:47:09, dmichael wrote: > > On ...
7 years, 9 months ago (2013-03-05 23:40:42 UTC) #6
dmichael (off chromium)
Sorry I didn't respond sooner. I haven't gotten the long tail of little tests, but ...
7 years, 9 months ago (2013-03-07 16:27:48 UTC) #7
jvoung (off chromium)
No problem, and thanks for making these tests run faster! Alright, let's see how it ...
7 years, 9 months ago (2013-03-07 17:19:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/12288013/27001
7 years, 9 months ago (2013-03-07 17:20:45 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-07 22:07:35 UTC) #10
Message was sent while issue was closed.
Change committed as 186787

Powered by Google App Engine
This is Rietveld 408576698