Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2947)

Unified Diff: ash/launcher/launcher_view.cc

Issue 12288012: Showing launcher items for windowed v1 apps - pinned or not. Also - don't show windowed v1 apps in … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing build breakage with clang Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/launcher/launcher_view.cc
diff --git a/ash/launcher/launcher_view.cc b/ash/launcher/launcher_view.cc
index 8356d47e0c11e741d22da463252057d9a321704f..09ee63d0cfa5cf7d0dcc27530515895905e3a9f1 100644
--- a/ash/launcher/launcher_view.cc
+++ b/ash/launcher/launcher_view.cc
@@ -686,6 +686,7 @@ views::View* LauncherView::CreateViewForItem(const LauncherItem& item) {
}
case TYPE_APP_SHORTCUT:
+ case TYPE_WINDOWED_APP:
case TYPE_PLATFORM_APP:
case TYPE_APP_PANEL: {
LauncherButton* button = LauncherButton::Create(
@@ -824,6 +825,7 @@ bool LauncherView::SameDragType(LauncherItemType typea,
case TYPE_PLATFORM_APP:
return (typeb == TYPE_TABBED || typeb == TYPE_PLATFORM_APP);
case TYPE_APP_SHORTCUT:
+ case TYPE_WINDOWED_APP:
case TYPE_APP_LIST:
case TYPE_APP_PANEL:
case TYPE_BROWSER_SHORTCUT:
@@ -1097,6 +1099,7 @@ void LauncherView::LauncherItemChanged(int model_index,
// Fallthrough for the new Launcher since it needs to show the activation
// change as well.
case TYPE_APP_SHORTCUT:
+ case TYPE_WINDOWED_APP:
case TYPE_PLATFORM_APP:
case TYPE_APP_PANEL: {
LauncherButton* button = static_cast<LauncherButton*>(view);
@@ -1218,6 +1221,7 @@ string16 LauncherView::GetAccessibleName(const views::View* view) {
case TYPE_TABBED:
case TYPE_APP_PANEL:
case TYPE_APP_SHORTCUT:
+ case TYPE_WINDOWED_APP:
case TYPE_PLATFORM_APP:
return delegate_->GetTitle(model_->items()[view_index]);
@@ -1259,6 +1263,7 @@ void LauncherView::ButtonPressed(views::Button* sender,
// Collect usage statistics before we decide what to do with the click.
switch (model_->items()[view_index].type) {
case TYPE_APP_SHORTCUT:
+ case TYPE_WINDOWED_APP:
case TYPE_PLATFORM_APP:
Shell::GetInstance()->delegate()->RecordUserMetricsAction(
UMA_LAUNCHER_CLICK_ON_APP);
« no previous file with comments | « ash/launcher/launcher_types.h ('k') | chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698