Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 12288012: Showing launcher items for windowed v1 apps - pinned or not. Also - don't show windowed v1 apps in … (Closed)

Created:
7 years, 10 months ago by Mr4D (OOO till 08-26)
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Showing launcher items for windowed v1 apps - pinned or not. Also - don't show windowed v1 apps in the browser list. BUG=170731 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183345 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183392

Patch Set 1 #

Patch Set 2 : Fix unit test #

Total comments: 6

Patch Set 3 : Addressed #

Patch Set 4 : Fixing unit test #

Patch Set 5 : Fixing build breakage with clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -26 lines) Patch
M ash/launcher/launcher_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/launcher/launcher_navigator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/launcher/launcher_types.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/launcher/launcher_view.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc View 1 2 4 chunks +22 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h View 1 2 4 chunks +23 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc View 1 2 12 chunks +85 lines, -17 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc View 1 2 1 chunk +174 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.h View 1 2 3 4 3 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.cc View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Mr4D (OOO till 08-26)
Added the new functionality to show launcher icons upon starting of windowed V1 applications. There ...
7 years, 10 months ago (2013-02-15 22:00:42 UTC) #1
sky
https://codereview.chromium.org/12288012/diff/13001/chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc File chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc (right): https://codereview.chromium.org/12288012/diff/13001/chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc#newcode55 chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc:55: launcher_controller()->UnlockAppWithID(v1_app_id_); Why do you need the lock/unlock? Shouldn't that ...
7 years, 10 months ago (2013-02-19 17:55:56 UTC) #2
Mr4D (OOO till 08-26)
Addressed as discussed. Please have another look! https://codereview.chromium.org/12288012/diff/13001/chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc File chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc (right): https://codereview.chromium.org/12288012/diff/13001/chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc#newcode55 chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc:55: launcher_controller()->UnlockAppWithID(v1_app_id_); As ...
7 years, 10 months ago (2013-02-19 19:22:13 UTC) #3
sky
LGTM
7 years, 10 months ago (2013-02-19 22:30:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/12288012/20004
7 years, 10 months ago (2013-02-19 22:39:04 UTC) #5
commit-bot: I haz the power
Change committed as 183345
7 years, 10 months ago (2013-02-20 00:36:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/12288012/21005
7 years, 10 months ago (2013-02-20 01:09:57 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 03:14:50 UTC) #8
Message was sent while issue was closed.
Change committed as 183392

Powered by Google App Engine
This is Rietveld 408576698