chrome/renderer/printing/print_web_view_helper_linux.cc - Issue 12288011: WebKit::WebFrame::printEnd on linux should be called before metafile is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper_linux.cc

Issue 12288011: WebKit::WebFrame::printEnd on linux should be called before metafile is closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/printing/print_web_view_helper_linux.cc

diff --git a/chrome/renderer/printing/print_web_view_helper_linux.cc b/chrome/renderer/printing/print_web_view_helper_linux.cc

index eae3a7be6fbf45211cd851937690da6eb430237f..50ff34de67b7dd47a964584fd008474e47dddcbc 100644

--- a/chrome/renderer/printing/print_web_view_helper_linux.cc

+++ b/chrome/renderer/printing/print_web_view_helper_linux.cc

@@ -92,6 +92,9 @@ bool PrintWebViewHelper::PrintPagesNative(WebKit::WebFrame* frame,

PrintPageInternal(page_params, canvas_size, frame, &metafile);

}

+ // WebKit::printEnd() for PDF should be called before metafile is closed.

+ FinishFramePrinting();

metafile.FinishDocument();

// Get the size of the resulting metafile.

« no previous file with comments | « chrome/renderer/printing/print_web_view_helper.cc ('k') | no next file » | no next file with comments »