WebKit::WebFrame::printEnd on linux should be called before metafile is closed.

chrome/renderer/printing/print_web_view_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/printing/print_web_view_helper.h"
 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 1232 matching lines @@
   if (store_print_pages_params) {
     old_print_pages_params_.reset(print_pages_params_.release());
   } else {
     print_pages_params_.reset();
     old_print_pages_params_.reset();
   }
 
   notify_browser_of_print_failure_ = true;
 }
 
+void PrintWebViewHelper::OnFramePreparedForPrintPages() {
+  PrintPages();
+  FinishFramePrinting();
+}
+
 void PrintWebViewHelper::PrintPages() {
-  // Delete prep_frame_view_ on exit.
-  scoped_ptr<PrepareFrameAndViewForPrint> prep_frame_view;
-  prep_frame_view.swap(prep_frame_view_);
-  if (!prep_frame_view)  // Printing is already canceled or failed.
+  if (!prep_frame_view_)  // Printing is already canceled or failed.
     return;
+  prep_frame_view_->StartPrinting();
 
-  prep_frame_view->StartPrinting();
-
-  int page_count = prep_frame_view->GetExpectedPageCount();
+  int page_count = prep_frame_view_->GetExpectedPageCount();
   if (!page_count) {
     LOG(ERROR) << "Can't print 0 pages.";
     return DidFinishPrinting(FAIL_PRINT);
   }
 
 #if !defined(OS_CHROMEOS)
   const PrintMsg_PrintPages_Params& params = *print_pages_params_;
   const PrintMsg_Print_Params& print_params = params.params;
 
   // TODO(vitalybuka): should be page_count or valid pages from params.pages.
   // See http://crbug.com/161576
   Send(new PrintHostMsg_DidGetPrintedPagesCount(routing_id(),
                                                 print_params.document_cookie,
                                                 page_count));
   if (print_params.preview_ui_id < 0) {
     // Printing for system dialog.
     int printed_count = params.pages.empty() ? page_count : params.pages.size();
     UMA_HISTOGRAM_COUNTS("PrintPreview.PageCount.SystemDialog", printed_count);
   }
 #endif  // !defined(OS_CHROMEOS)
 
-  if (!PrintPagesNative(prep_frame_view->frame(), prep_frame_view->node(),
-                        page_count, prep_frame_view->GetPrintCanvasSize())) {
+  if (!PrintPagesNative(prep_frame_view_->frame(), prep_frame_view_->node(),
+                        page_count, prep_frame_view_->GetPrintCanvasSize())) {
     LOG(ERROR) << "Printing failed.";
     return DidFinishPrinting(FAIL_PRINT);
   }
 }
 
+void PrintWebViewHelper::FinishFramePrinting() {
+  prep_frame_view_.reset();
+}
+
 #if defined(OS_MACOSX) || defined(OS_WIN)
 bool PrintWebViewHelper::PrintPagesNative(WebKit::WebFrame* frame,
                                           const WebKit::WebNode& node,
                                           int page_count,
                                           const gfx::Size& canvas_size) {
   const PrintMsg_PrintPages_Params& params = *print_pages_params_;
   const PrintMsg_Print_Params& print_params = params.params;
 
   PrintMsg_PrintPage_Params page_params;
   page_params.params = print_params;
@@ skipping 228 matching lines @@
     return false;
   const PrintMsg_PrintPages_Params& params = *print_pages_params_;
   const PrintMsg_Print_Params& print_params = params.params;
   prep_frame_view_.reset(
       new PrepareFrameAndViewForPrint(print_params, frame, node,
                                       ignore_css_margins_));
   DCHECK(!print_pages_params_->params.selection_only ||
          print_pages_params_->pages.empty());
   prep_frame_view_->CopySelectionIfNeeded(
       render_view()->GetWebkitPreferences(),
-      base::Bind(&PrintWebViewHelper::PrintPages, base::Unretained(this)));
+      base::Bind(&PrintWebViewHelper::OnFramePreparedForPrintPages,
+                 base::Unretained(this)));
   return true;
 }
 
 #if defined(OS_POSIX)
 bool PrintWebViewHelper::CopyMetafileDataToSharedMem(
     Metafile* metafile,
     base::SharedMemoryHandle* shared_mem_handle) {
   uint32 buf_size = metafile->GetDataSize();
   scoped_ptr<base::SharedMemory> shared_buf(
       content::RenderThread::Get()->HostAllocateSharedMemoryBuffer(
@@ skipping 385 matching lines @@
 }
 
 void PrintWebViewHelper::PrintPreviewContext::ClearContext() {
   prep_frame_view_.reset();
   metafile_.reset();
   pages_to_render_.clear();
   error_ = PREVIEW_ERROR_NONE;
 }
 
 }  // namespace printing