Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 12287025: Use qualified ITEMIDLISTs in CreateOrderBlob (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Use qualified ITEMIDLISTs in CreateOrderBlob Win64 builds fail on alignment error if you use the wrong struct type. BUG=166496 R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/importer/ie_importer_unittest_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jschuh
PTAL. Trivial Win64 build fix.
7 years, 10 months ago (2013-02-16 08:28:41 UTC) #1
Ilya Sherman
LGTM
7 years, 10 months ago (2013-02-16 09:28:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12287025/1
7 years, 10 months ago (2013-02-16 09:28:18 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-16 19:16:00 UTC) #4
Message was sent while issue was closed.
Change committed as 182998

Powered by Google App Engine
This is Rietveld 408576698