Move the chromeHidden.toJSON paranoia out of event.js and into json.js, a new

Move the chromeHidden.toJSON paranoia out of event.js and into json.js, a new
and much smaller file. Having it in event.js means the heavyweight Event class
needs to be eagerly required on extension startup. Now, only json.js does.

R=koz@chromium.org
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183365

[not at google - send to devlin, 2013-02-15 21:23:34]

This is really for https://codereview.chromium.org/11571014/.

[not at google - send to devlin, 2013-02-19 17:48:25]

ping

[koz (OOO until 15th September), 2013-02-19 23:19:08]

Sorry for the delay! Awesome change.

lgtm

https://codereview.chromium.org/12287011/diff/2001/chrome/renderer/extensions...
File chrome/renderer/extensions/json_js_unittest.cc (right):

https://codereview.chromium.org/12287011/diff/2001/chrome/renderer/extensions...
chrome/renderer/extensions/json_js_unittest.cc:21: "var assert =
requireNative('assert');"
Nit: if you add \n to your lines you get line numbers in your exceptions.

https://codereview.chromium.org/12287011/diff/2001/chrome/renderer/extensions...
chrome/renderer/extensions/json_js_unittest.cc:52: RegisterModule("test",
requires() + overrides + test_body());
Cool test :-)

You may want to test that after the json.parse() call the user-overridden
toJSON()s are preserved.

[not at google - send to devlin, 2013-02-19 23:52:12]

https://codereview.chromium.org/12287011/diff/2001/chrome/renderer/extensions...
File chrome/renderer/extensions/json_js_unittest.cc (right):

https://codereview.chromium.org/12287011/diff/2001/chrome/renderer/extensions...
chrome/renderer/extensions/json_js_unittest.cc:21: "var assert =
requireNative('assert');"
On 2013/02/19 23:19:08, koz wrote:
> Nit: if you add \n to your lines you get line numbers in your exceptions.

Done.

https://codereview.chromium.org/12287011/diff/2001/chrome/renderer/extensions...
chrome/renderer/extensions/json_js_unittest.cc:52: RegisterModule("test",
requires() + overrides + test_body());
On 2013/02/19 23:19:08, koz wrote:
> Cool test :-)
> 
> You may want to test that after the json.parse() call the user-overridden
> toJSON()s are preserved.

Done.

https://codereview.chromium.org/12287011/diff/2001/chrome/renderer/extensions...
chrome/renderer/extensions/json_js_unittest.cc:52: RegisterModule("test",
requires() + overrides + test_body());
On 2013/02/19 23:19:08, koz wrote:
> Cool test :-)
> 
> You may want to test that after the json.parse() call the user-overridden
> toJSON()s are preserved.

Done.

[commit-bot: I haz the power, 2013-02-19 23:56:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/12287011/8001

[commit-bot: I haz the power, 2013-02-20 01:55:02]

Change committed as 183365