Issue 12286007: Revert "Revert 182527" ([Sync] Make SESSIONS an implicit type)

Issue 12286007: Revert "Revert 182527" ([Sync] Make SESSIONS an implicit type) (Closed)

Created:
7 years, 10 months ago by Nicolas Zea

Modified:
7 years, 9 months ago

Reviewers:

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, akalin, Raghu Simha, arv+watch_chromium.org, estade+watch_chromium.org, haitaol1, tim (not reviewing), pedrosimonetti+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Revert 182527" ([Sync] Make SESSIONS an implicit type) Win_aura compile failure seems like bot flakiness Original codereview at https://codereview.chromium.org/11961030/ TBR=tim@chromium.org,jhawkins@chromium.org BUG=170162 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185743

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -48 lines)			Patch
M	chrome/app/generated_resources.grd	View		2 chunks	+18 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/sync_setup_overlay.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/sync_setup_overlay.js	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/glue/model_association_manager.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory_impl.cc	View		5 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/sync_prefs.cc	View	1	6 chunks	+23 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/sync_prefs_unittest.cc	View	1	3 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/enable_disable_test.cc	View		4 chunks	+21 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/user_selectable_sync_type.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/foreign_session_handler.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler_unittest.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/internal_api/public/base/model_type.h	View	1	2 chunks	+20 lines, -1 line	0 comments	Download
M	sync/protocol/proto_value_conversions.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sync/protocol/proto_value_conversions_unittest.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	sync/protocol/sync.proto	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	sync/syncable/model_type.cc	View	1	5 chunks	+14 lines, -6 lines	0 comments	Download
M	sync/syncable/nigori_util.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sync/util/data_type_histogram.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/12286007/9001

7 years, 9 months ago (2013-03-02 01:09:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/12286007/9001

7 years, 9 months ago (2013-03-02 16:06:10 UTC) #2

Message was sent while issue was closed.

Change committed as 185743

Expand Messages | Collapse Messages