Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 12285016: cros: Use /var/run/debugfs_gpu for graphics memory info (Closed)

Created:
7 years, 10 months ago by James Cook
Modified:
7 years, 10 months ago
Reviewers:
brettw, DaveMoore
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

cros: Use /var/run/debugfs_gpu for graphics memory info The /sys/kernel/debug file system was recently made non-world-readable, but we've added a bind mount in /var/run for this information. Switch to the new path. BUG=175828 TEST=manual, on a device about:discards shows a "Graphics" line at the bottom Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M base/process_util_linux.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
James Cook
Dave, PTAL. I moved the OS_CHROMEOS ifdef so we don't try to read this file ...
7 years, 10 months ago (2013-02-16 00:13:35 UTC) #1
DaveMoore
lgtm
7 years, 10 months ago (2013-02-16 00:49:41 UTC) #2
James Cook
brettw, can I get base/ OWNERS approval? This is a fix-up to a change you ...
7 years, 10 months ago (2013-02-16 01:02:30 UTC) #3
brettw
lgtm
7 years, 10 months ago (2013-02-16 04:35:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/12285016/1
7 years, 10 months ago (2013-02-18 02:55:31 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-18 06:11:08 UTC) #6
Message was sent while issue was closed.
Change committed as 183065

Powered by Google App Engine
This is Rietveld 408576698