chrome/common/extensions/docs/examples/extensions/native_messaging/popup.js - Issue 12285015: Require manifests for native messaging hosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/extensions/native_messaging/popup.js

Issue 12285015: Require manifests for native messaging hosts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/docs/examples/extensions/native_messaging/popup.js

diff --git a/chrome/common/extensions/docs/examples/extensions/native_messaging/popup.js b/chrome/common/extensions/docs/examples/extensions/native_messaging/popup.js

index 07c6da46870e33718c66d573dab1bed05c8d4308..e674dfb9bf33040ccaadf6d23fb5a418b6bb18b0 100644

--- a/chrome/common/extensions/docs/examples/extensions/native_messaging/popup.js

+++ b/chrome/common/extensions/docs/examples/extensions/native_messaging/popup.js

@@ -14,8 +14,7 @@ function gotNativeMessage(message) {

function sendNativeMessage() {

if (!port) {

- app = navigator.platform.match(/win/i) ? 'echo.bat' : 'echo.py';

- port = chrome.extension.connectNative(app);

+ port = chrome.extension.connectNative('com.google.chrome.test.echo');

port.onMessage.addListener(gotNativeMessage);

document.getElementById('input-text').style.display = 'block';

document.getElementById('send-native-message').innerHTML = 'Send Message';

« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/test/data/extensions/api_test/native_messaging/manifest.json » ('j') | no next file with comments »