Require manifests for native messaging hosts.

chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

Index: chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc
diff --git a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4a8a24d2574c659a667fa1e43aec0f9653569b9d
--- /dev/null
+++ b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc
@@ -0,0 +1,127 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/messaging/native_messaging_host_manifest.h"
+
+#include "base/file_util.h"
+#include "base/files/file_path.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/json/string_escape.h"
+#include "extensions/common/url_pattern_set.h"
+#include "googleurl/src/gurl.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+const char kTestHostName[] = "com.chrome.test.native_host";
+#if defined(OS_WIN)
+const char kTestHostPath[] = "C:\\ProgramFiles\\host.exe";
+#else
+const char kTestHostPath[] = "/usr/bin/host";
+#endif
+const char kTestOrigin[] =
+    "chrome-extension://knldjmfmopnpolahpmmgbagdohdnhkik/";
+
+class NativeMessagingHostManifestTest : public ::testing::Test {
+ public:
+  virtual void SetUp() OVERRIDE {
+    ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+    manifest_path_ = temp_dir_.path().AppendASCII("test.json");
+  }
+
+ protected:
+  bool WriteManifest(const std::string& name,
+                     const std::string& path,
+                     const std::string& origin) {
+    std::string escaped_path;
+    base::JsonDoubleQuote(path, false, &escaped_path);
+    return WriteManifest("{"
+      "  \"name\": \"" + name + "\","
+      "  \"description\": \"Native Messaging Test\","
+      "  \"path\": \"" + escaped_path + "\","
+      "  \"type\": \"stdio\","
+      "  \"allowed_origins\": ["
+      "    \"" + origin + "\""
+      "  ]"
+      "}");
+  }
+
+  bool WriteManifest(const std::string& manifest_content) {
+    return file_util::WriteFile(
+        manifest_path_, manifest_content.data(), manifest_content.size());
+  }
+
+  base::ScopedTempDir temp_dir_;
+  base::FilePath manifest_path_;
+};
+
+TEST_F(NativeMessagingHostManifestTest, HostNameValidation) {
+  EXPECT_TRUE(NativeMessagingHostManifest::IsValidName("a"));
+  EXPECT_TRUE(NativeMessagingHostManifest::IsValidName("foo"));
+  EXPECT_TRUE(NativeMessagingHostManifest::IsValidName("foo132"));
+  EXPECT_TRUE(NativeMessagingHostManifest::IsValidName("foo.bar"));
+  EXPECT_TRUE(NativeMessagingHostManifest::IsValidName("foo.bar2"));
+  EXPECT_TRUE(NativeMessagingHostManifest::IsValidName("a._.c"));
+  EXPECT_TRUE(NativeMessagingHostManifest::IsValidName("a._.c"));
+  EXPECT_FALSE(NativeMessagingHostManifest::IsValidName("A.b"));
+  EXPECT_FALSE(NativeMessagingHostManifest::IsValidName("a..b"));
+  EXPECT_FALSE(NativeMessagingHostManifest::IsValidName(".a"));
+  EXPECT_FALSE(NativeMessagingHostManifest::IsValidName("b."));
+  EXPECT_FALSE(NativeMessagingHostManifest::IsValidName("a*"));
+}
+
+TEST_F(NativeMessagingHostManifestTest, LoadValid) {
+  ASSERT_TRUE(WriteManifest(kTestHostName, kTestHostPath, kTestOrigin));
+
+  std::string error_message;
+  scoped_ptr<NativeMessagingHostManifest> manifest =
+      NativeMessagingHostManifest::Load(manifest_path_, &error_message);
+  ASSERT_TRUE(manifest) << "Failed to load manifest: " << error_message;
+  EXPECT_TRUE(error_message.empty());
+
+  EXPECT_EQ(manifest->name(), "com.chrome.test.native_host");
+  EXPECT_EQ(manifest->description(), "Native Messaging Test");
+  EXPECT_EQ(manifest->interface(),
+            NativeMessagingHostManifest::HOST_INTERFACE_STDIO);
+  EXPECT_EQ(manifest->path(), base::FilePath::FromUTF8Unsafe(kTestHostPath));
+  EXPECT_TRUE(manifest->allowed_origins().MatchesSecurityOrigin(
+      GURL("chrome-extension://knldjmfmopnpolahpmmgbagdohdnhkik/")));
+  EXPECT_FALSE(manifest->allowed_origins().MatchesSecurityOrigin(
+      GURL("chrome-extension://jnldjmfmopnpolahpmmgbagdohdnhkik/")));
+}
+
+TEST_F(NativeMessagingHostManifestTest, InvalidName) {
+  ASSERT_TRUE(WriteManifest(".com.chrome.test.native_host",
+                            kTestHostPath, kTestOrigin));
+
+  std::string error_message;
+  scoped_ptr<NativeMessagingHostManifest> manifest =
+      NativeMessagingHostManifest::Load(manifest_path_, &error_message);
+  ASSERT_FALSE(manifest);
+  EXPECT_FALSE(error_message.empty());
+}
+
+TEST_F(NativeMessagingHostManifestTest, RelativePath) {
+  ASSERT_TRUE(WriteManifest(kTestHostName, "host.exe", kTestOrigin));
+
+  std::string error_message;
+  scoped_ptr<NativeMessagingHostManifest> manifest =
+      NativeMessagingHostManifest::Load(manifest_path_, &error_message);
+  ASSERT_FALSE(manifest);
+  EXPECT_FALSE(error_message.empty());
+}
+
+// Verify that match-all origins are rejected.
+TEST_F(NativeMessagingHostManifestTest, MatchAllOrigin) {
+  ASSERT_TRUE(WriteManifest(kTestHostName, kTestHostPath,
+                            "chrome-extension://*/"));
+
+  std::string error_message;
+  scoped_ptr<NativeMessagingHostManifest> manifest =
+      NativeMessagingHostManifest::Load(manifest_path_, &error_message);
+  ASSERT_FALSE(manifest);
+  EXPECT_FALSE(error_message.empty());
+}
+
+}  // namespace extensions