Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 12285011: Reducing the maximize limit to a tine screen size - which will turn this off until we have the full (Closed)

Created:
7 years, 10 months ago by Mr4D (OOO till 08-26)
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Reducing the maximize limit to a tine screen size - which will turn this off until we have the full logic defined BUG=173247 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183453

Patch Set 1 #

Patch Set 2 : Reducing the maximize limit to a tine screen size - which will turn this off until we have the full… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M chrome/browser/ui/window_sizer/window_sizer.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 1 chunk +18 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
7 years, 10 months ago (2013-02-15 23:38:05 UTC) #1
sky
An int here is a bit confusing. Can you make it a boolean?
7 years, 10 months ago (2013-02-19 17:26:15 UTC) #2
sky
LGTM
7 years, 10 months ago (2013-02-19 17:49:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/12285011/2002
7 years, 10 months ago (2013-02-19 17:51:18 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 10:13:50 UTC) #5
Message was sent while issue was closed.
Change committed as 183453

Powered by Google App Engine
This is Rietveld 408576698