Add a TODO comment to remind us when we will be able to remove the

Move the rc4_wordconv suppression to the new suppressions_linux.txt
file because it is only needed on Linux now.

Add a TODO comment to remind us when we will be able to remove the
rc4_wordconv suppression.

R=rsleevi@chromium.org
BUG=174140
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183460

[wtc, 2013-02-15 22:34:11]

rsleevi: please review.

glider,timurrrr: is it possible to make this suppression
Linux only?  I have fixed this invalid read in our own copy
of NSS on Mac OS X.  On Linux, Chromium uses the system NSS
libraries, so I still need this suppression for Linux.

[Timur Iskhodzhanov, 2013-02-17 10:31:12]

2013/2/16  <wtc@chromium.org>:
> glider,timurrrr: is it possible to make this suppression
> Linux only?  I have fixed this invalid read in our own copy
> of NSS on Mac OS X.  On Linux, Chromium uses the system NSS
> libraries, so I still need this suppression for Linux.
I think tools/valgrind/memcheck/suppressions_linux.txt should do the trick.
Let me check on Monday.

[Timur Iskhodzhanov, 2013-02-19 10:36:28]

2013/2/17 Timur Iskhodzhanov <timurrrr@chromium.org>:
> I think tools/valgrind/memcheck/suppressions_linux.txt should do the trick.
Yes it does.

[wtc, 2013-02-19 19:08:57]

On 2013/02/17 10:31:12, Timur Iskhodzhanov wrote:
>
> I think tools/valgrind/memcheck/suppressions_linux.txt should do the trick.

Timur: thank you for looking into this.

Based on the code in tools/valgrind/{suppressions.py,test_suppressions.py}
that rsleevi pointed out to me last week, I believe those two files
also need to be updated to support
tools/valgrind/memcheck/suppressions_linux.txt.

[Timur Iskhodzhanov, 2013-02-19 19:19:17]

Yes, absolutely!
Please go ahead committing and we'll handle the scripts.

Reid,
while you're sheriffing - can you please generalize the
*suppressions.py to look for suppressions_linux.txt too?

2013/2/19  <wtc@chromium.org>:
> On 2013/02/17 10:31:12, Timur Iskhodzhanov wrote:
>
>> I think tools/valgrind/memcheck/suppressions_linux.txt should do the
>> trick.
>
>
> Timur: thank you for looking into this.
>
> Based on the code in tools/valgrind/{suppressions.py,test_suppressions.py}
> that rsleevi pointed out to me last week, I believe those two files
> also need to be updated to support
> tools/valgrind/memcheck/suppressions_linux.txt.
>
> https://codereview.chromium.org/12284008/

[wtc, 2013-02-19 19:35:55]

I added suppressions_linux.txt. Please review patch set 2.
Thanks.

https://codereview.chromium.org/12284008/diff/6001/tools/valgrind/memcheck/su...
File tools/valgrind/memcheck/suppressions_linux.txt (right):

https://codereview.chromium.org/12284008/diff/6001/tools/valgrind/memcheck/su...
tools/valgrind/memcheck/suppressions_linux.txt:15: # The InvalidRead error in
rc4_wordconv is intentional.

This suppression was in Section 2 of suppressions.txt
because it is an intentional invalid read. I put it in
Section 1 of this file because this is in third-party code
(system NSS libraries).

[Timur Iskhodzhanov, 2013-02-19 20:15:43]

LGTM

[anagy4698, 2013-02-19 20:19:15]

Ejha, az összes fontos üzenetet elolvasta a beérkezett levelek közül!


2013/2/19 Timur Iskhodzhanov <timurrrr@chromium.org>

> LGTM
>



-- 
anagy4698@gmail.com.

[Reid Kleckner (google), 2013-02-19 20:26:43]

Sure.


On Tue, Feb 19, 2013 at 2:18 PM, Timur Iskhodzhanov
<timurrrr@chromium.org>wrote:

> Yes, absolutely!
> Please go ahead committing and we'll handle the scripts.
>
> Reid,
> while you're sheriffing - can you please generalize the
> *suppressions.py to look for suppressions_linux.txt too?
>
> 2013/2/19  <wtc@chromium.org>:
> > On 2013/02/17 10:31:12, Timur Iskhodzhanov wrote:
> >
> >> I think tools/valgrind/memcheck/suppressions_linux.txt should do the
> >> trick.
> >
> >
> > Timur: thank you for looking into this.
> >
> > Based on the code in
> tools/valgrind/{suppressions.py,test_suppressions.py}
> > that rsleevi pointed out to me last week, I believe those two files
> > also need to be updated to support
> > tools/valgrind/memcheck/suppressions_linux.txt.
> >
> > https://codereview.chromium.org/12284008/
>

[commit-bot: I haz the power, 2013-02-19 22:10:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/12284008/6001

[commit-bot: I haz the power, 2013-02-20 10:28:47]

Change committed as 183460