[content shell] implement pathToLocalResource

[content shell] implement pathToLocalResource

On windows, this method replaces a /tmp/ prefix with the actual temp path. Otherwise, it removes superfluous leading slashes from file: URLs and passes the path on the rewriteLayoutTestURL

BUG=111316
R=thakis@chromium.org
TEST=http/tests/plugins/post-url-file.html passes


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183473

[Nico, 2013-02-19 15:51:50]

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
File content/shell/webkit_test_runner.cc (right):

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:314: return
base_url.Resolve(resource.substr(kTempPrefixLength)).spec();
Hm, is there code for this somewhere else already? This looks like something
that's probably been implemented many times?

[Nico, 2013-02-19 16:02:53]

this exists nowhere else per irc.

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
File content/shell/webkit_test_runner.cc (right):

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:310: if (resource.find("/tmp/")) {
.find("/tmp/") == 0?

(or indexof() instead of find(); there's some function which gives you the index
i think)

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:312: const unsigned kTempPrefixLength = 5;
strlen("/tmp") instead of 5

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:323: lower_url.begin(), lower_url.end(),
lower_url.begin(), tolower);
StringToLowerASCII?

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:324: while (!lower_url.find("file:////")) {
Probably simpler if you create a new temporary each time instead of keeping two
up to date?


while (StringToLowerASCII(string(resource).find("file:////") == 0)
   substr

[Nico, 2013-02-19 16:03:02]

s/irc/gtalk/

[jochen (gone - plz use gerrit), 2013-02-20 09:06:13]

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
File content/shell/webkit_test_runner.cc (right):

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:310: if (resource.find("/tmp/")) {
On 2013/02/19 16:02:53, Nico wrote:
> .find("/tmp/") == 0?
> 
> (or indexof() instead of find(); there's some function which gives you the
index
> i think)

Done.

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:312: const unsigned kTempPrefixLength = 5;
On 2013/02/19 16:02:53, Nico wrote:
> strlen("/tmp") instead of 5

Done.

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:314: return
base_url.Resolve(resource.substr(kTempPrefixLength)).spec();
On 2013/02/19 15:51:50, Nico wrote:
> Hm, is there code for this somewhere else already? This looks like something
> that's probably been implemented many times?
nope

https://codereview.chromium.org/12282041/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:324: while (!lower_url.find("file:////")) {
On 2013/02/19 16:02:53, Nico wrote:
> Probably simpler if you create a new temporary each time instead of keeping
two
> up to date?
> 
> 
> while (StringToLowerASCII(string(resource).find("file:////") == 0)
>    substr

Done.

[Nico, 2013-02-20 09:10:37]

lgtm

https://codereview.chromium.org/12282041/diff/7001/content/shell/webkit_test_...
File content/shell/webkit_test_runner.cc (right):

https://codereview.chromium.org/12282041/diff/7001/content/shell/webkit_test_...
content/shell/webkit_test_runner.cc:322: result = result.substr(0, 8) +
result.substr(9);
nit: maybe strlen("file:///") instead of 8 and strlen("file:////") instead of 9

[commit-bot: I haz the power, 2013-02-20 09:15:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/12282041/12004

[commit-bot: I haz the power, 2013-02-20 11:26:21]

Change committed as 183473