Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2441)

Unified Diff: base/android/jni_local_ref_extensions.cc

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed assortment of nits Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/jni_local_ref_extensions.cc
diff --git a/base/android/jni_local_ref_extensions.cc b/base/android/jni_local_ref_extensions.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3da2f06f6deb7e8ea23f12d4171e98a23afaa14f
--- /dev/null
+++ b/base/android/jni_local_ref_extensions.cc
@@ -0,0 +1,29 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/android/jni_local_ref_extensions.h"
+
+namespace base {
+namespace android {
+
+string16 SafeJavaStringToUTF16(ScopedJavaLocalRef<jstring> jstring) {
+ if (jstring.is_null())
+ return string16();
+
+ return ConvertJavaStringToUTF16(jstring);
+}
+
+void SafeJavaStringArrayToStringVector(
+ ScopedJavaLocalRef<jobjectArray> jarray,
+ JNIEnv* env,
+ std::vector<string16>* stringVector) {
Ilya Sherman 2013/03/05 00:42:38 nit: Indent these three lines two more spaces each
Ilya Sherman 2013/03/05 00:42:38 nit: Use hacker_case, not camelCase.
apiccion 2013/03/09 00:53:41 Done.
apiccion 2013/03/09 00:53:41 Done.
+ if (!jarray.is_null()) {
+ base::android::AppendJavaStringArrayToStringVector(env,
+ jarray.obj(),
+ stringVector);
+ }
+}
+
+} // namespace android
+} // namespace base

Powered by Google App Engine
This is Rietveld 408576698