Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

components/autofill/browser/android/auxiliary_profile_loader_android.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_AUTOFILL_BROWSER_ANDROID_AUXILIARY_PROFILE_LOADER_ANDROID_H_
+#define COMPONENTS_AUTOFILL_BROWSER_ANDROID_AUXILIARY_PROFILE_LOADER_ANDROID_H_
+
+#include <vector>
+
+#include "base/android/jni_android.h"
+#include "base/string16.h"
+
+namespace autofill {
+
+bool RegisterAuxiliaryProfileLoader(JNIEnv* env);
+
+// This class loads user's contact information from their device.
+// The populated data corresponds to the user's 'Me' profile in their
+// contact list.
+class AuxiliaryProfileLoaderAndroid {
+ public:
+  AuxiliaryProfileLoaderAndroid();
+  virtual ~AuxiliaryProfileLoaderAndroid();
+
+  // Init method should be called after object initialization.
+  // context parameter is an Android context.
+  void Init(JNIEnv* env, const jobject& context);
+
+  // Returns address street.
+  virtual string16 GetStreet() const;
+  // Returns address post office box.
+  virtual string16 GetPostOfficeBox() const;
+  // Returns address neighborhood (e.g. Noe Valley, Nob Hill, Twin Peaks, ...).
+  virtual string16 GetNeighborhood() const;
+  // Returns address region such as state or province information
+  // (e.g. Ontario, California, Hubei).
+  virtual string16 GetRegion() const;
+  // Returns address city.
+  virtual string16 GetCity() const;
+  // Returns address postal code or zip code.
+  virtual string16 GetPostalCode() const;
+  // Returns address country.
+  virtual string16 GetCountry() const;
+
+  // Returns contact's first name.
+  virtual string16 GetFirstName() const;
+  // Returns contact's middle name.
+  virtual string16 GetMiddleName() const;
+  // Returns contact's last name.
+  virtual string16 GetLastName() const;
+  // Returns contact's suffix (e.g. Ph.D, M.D., ...).
+  virtual string16 GetSuffix() const;
+
+  // Populates string vector parameter with contact's email addresses.
+  virtual void GetEmailAddresses(std::vector<string16>* email_addresses) const;
+
+  // Populates string vector parameter with contact's phones numbers.
+  virtual void GetPhoneNumbers(std::vector<string16>* phone_numbers) const;
+
+ private:
+  JNIEnv* env_;

[Yaron, 2013/03/16 00:15:30]

Hmm. We generally don't cache the env pointer or a local ref especially if can
be accessed from multiple threads. In this case it looks like you're doing it in
a single thread of execution and throwing it away after so I guess it's ok. 

[apiccion, 2013/03/18 19:30:36]

Thanks. I will keep this in mind for the future.

On 2013/03/16 00:15:30, Yaron wrote:

+  // The reference to java |PersonalAutofillPopulator| which
+  // actually extracts users contact information from the physical device
+  base::android::ScopedJavaLocalRef<jobject> populator_;
+  DISALLOW_COPY_AND_ASSIGN(AuxiliaryProfileLoaderAndroid);
+};
+
+} // namespace
+
+#endif  // COMPONENTS_AUTOFILL_BROWSER_ANDROID_AUXILIARY_PROFILE_LOADER_ANDROID_H_