Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

chrome/browser/autofill/android/auxiliary_profile_loader_android.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_ANDROID_AUXILIARY_PROFILE_LOADER_ANDROID_H_
+#define CHROME_BROWSER_AUTOFILL_ANDROID_AUXILIARY_PROFILE_LOADER_ANDROID_H_
+
+#include <vector>
+
+#include "base/string16.h"
+
+namespace autofill {
+
+class AuxiliaryProfileLoader {
+  // Abstract interface class provides interface for loading
+  // contact information.

[Ilya Sherman, 2013/03/05 00:42:38]

Why do you need an abstract interface for this?  That is, why not rename
AuxiliaryProfileLoaderImplAndroid to AuxiliaryProfileLoaderAndroid and just use
that class name everywhere?

[Ilya Sherman, 2013/03/05 00:42:38]

nit: Comment goes above the class.

[apiccion, 2013/03/09 00:53:41]

Done.

+ public:
+  virtual ~AuxiliaryProfileLoader() {}
+
+  // Returns address street.
+  virtual string16 GetStreet() const = 0;
+  // Returns address post office box.
+  virtual string16 GetPostOfficeBox() const = 0;
+  // Returns address neighborhood (e.g. Noe Valley, Nob Hill, Twin Peaks, ...).
+  virtual string16 GetNeighborhood() const = 0;
+  // Returns address region such as state or province information
+  // (e.g. Ontario, California, Hubei).
+  virtual string16 GetRegion() const = 0;
+  // Returns address city.
+  virtual string16 GetCity() const = 0;
+  // Returns address postal code or zip code.
+  virtual string16 GetPostalCode() const = 0;
+  // Returns address country.
+  virtual string16 GetCountry() const = 0;
+
+  // Returns contact's first name.
+  virtual string16 GetFirstName() const = 0;
+  // Returns contact's middle name.
+  virtual string16 GetMiddleName() const = 0;
+  // Returns contact's last name.
+  virtual string16 GetLastName() const = 0;
+  // Returns contact's suffix (e.g. Ph.D, M.D., ...).
+  virtual string16 GetSuffix() const = 0;
+
+  // Populates string vector parameter with contact's email addresses.
+  virtual void GetEmailAddresses(std::vector<string16>*) const = 0;

[Ilya Sherman, 2013/03/05 00:42:38]

nit: Parameters should always be named.

[apiccion, 2013/03/09 00:53:41]

Done.

+
+  // Populates string vector parameter with contact's phones numbers.
+  virtual void GetPhoneNumbers(std::vector<string16>*) const = 0;

[Ilya Sherman, 2013/03/05 00:42:38]

nit: Parameters should always be named.

[apiccion, 2013/03/09 00:53:41]

Done.

+};
+
+} // namespace
+
+#endif  // CHROME_BROWSER_AUTOFILL_ANDROID_AUXILIARY_PROFILE_LOADER_ANDROID_H_