Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: base/android/jni_local_ref_extensions.h

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed assortment of nits Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef BASE_ANDROID_JNI_LOCAL_REF_EXTENSIONS_H_
6 #define BASE_ANDROID_JNI_LOCAL_REF_EXTENSIONS_H_
7
8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h"
11
12 namespace base {
13 namespace android {
14
15 // Returns empty string if java string is null,
Ilya Sherman 2013/03/05 00:42:38 nit: "Returns and empty string if the Java string
apiccion 2013/03/09 00:53:41 Done.
16 // otherwise converts and returns the string.
17 string16 SafeJavaStringToUTF16(ScopedJavaLocalRef<jstring> jstring);
18
19 // Checks if java array is null and copies contents into stringVector
Ilya Sherman 2013/03/05 00:42:38 nit: Perhaps something like "Fills |string_vector|
apiccion 2013/03/09 00:53:41 Done.
20 void SafeJavaStringArrayToStringVector(
21 ScopedJavaLocalRef<jobjectArray> jarray,
22 JNIEnv* env,
23 std::vector<string16>* stringVector);
Ilya Sherman 2013/03/05 00:42:38 nit: Use hacker_case, not camelCase.
apiccion 2013/03/09 00:53:41 Done.
24
25 } // namespace android
26 } // namespace base
27
28 #endif // BASE_ANDROID_JNI_LOCAL_REF_EXTENSIONS_H_
OLDNEW
« no previous file with comments | « no previous file | base/android/jni_local_ref_extensions.cc » ('j') | base/android/jni_local_ref_extensions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698