chrome/browser/autofill/auxiliary_profile_loader_android.h - Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/autofill/auxiliary_profile_loader_android.h

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/autofill/auxiliary_profile_impl_unittest.cc ('K') | « chrome/browser/autofill/auxiliary_profile_impl_unittest.cc ('k') | chrome/browser/autofill/auxiliary_profile_loader_android.cc » ('j') | chrome/browser/autofill/auxiliary_profile_loader_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_ANDROID_H_

	6 #define CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_ANDROID_H_

	7

	8 #include "base/android/jni_android.h"

	9 #include "chrome/browser/autofill/i_auxiliary_profile_loader.h"

	10

	11 bool RegisterAuxiliaryProfileLoader(JNIEnv* env);

	12

	13 class AuxiliaryProfileLoaderAndroid : public IAuxiliaryProfileLoader {
	David Trainor- moved to gerrit 2013/02/27 07:49:28 disallow copy and assign macro disallow copy and assign macro apiccion 2013/02/28 01:31:04 Done. Show quoted text On 2013/02/27 07:49:28, David Trainor wrote: > disallow copy and assign macro Done. apiccion 2013/02/28 01:31:04 Done. Show quoted text On 2013/02/27 07:49:28, David Trainor wrote: > disallow copy and assign macro Done.
	14 public:

	15 explicit AuxiliaryProfileLoaderAndroid();

	16

	17 // Address info
	David Trainor- moved to gerrit 2013/02/27 07:49:28 Don't need these comments. Need something like: / Don't need these comments. Need something like: // IAuxiliaryProfileLoader implementation apiccion 2013/02/28 01:31:04 Done. Show quoted text On 2013/02/27 07:49:28, David Trainor wrote: > Don't need these comments. Need something like: > // IAuxiliaryProfileLoader implementation Done.
	18 virtual string16 GetStreet();
	David Trainor- moved to gerrit 2013/02/27 07:49:28 Add OVERRIDE to the end of every overridden method Add OVERRIDE to the end of every overridden method. apiccion 2013/02/28 01:31:04 Done. Show quoted text On 2013/02/27 07:49:28, David Trainor wrote: > Add OVERRIDE to the end of every overridden method. Done.
	19 virtual string16 GetPobox();

	20 virtual string16 GetNeighborhood();

	21 virtual string16 GetRegion();

	22 virtual string16 GetCity();

	23 virtual string16 GetPostalCode();

	24 virtual string16 GetCountry();

	25

	26 // Name info

	27 virtual string16 GetFirstName();

	28 virtual string16 GetMiddleName();

	29 virtual string16 GetLastName();

	30 virtual string16 GetSuffix();

	31

	32 // Email info

	33 virtual std::vector<string16> GetEmailAddresses();

	34

	35 // Phone info

	36 virtual std::vector<string16> GetPhoneNumbers();

	37

	38 private:

	39 base::android::ScopedJavaLocalRef<jobject> populator_;

	40 JNIEnv* env_;

	41 };

	42 #endif // CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_ANDROID_H_

OLD	NEW