Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 12279012: Change the modem reset command on cellular activation completion. (Closed)

Created:
7 years, 10 months ago by rkc
Modified:
7 years, 10 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change the modem reset command on cellular activation completion. Instead of calling ModemReset on completing activation for an LTE modem, instead call the new CompleteCellularActivation shill service method. R=gspencer@chromium.org,benchan@chromium.org BUG=172526 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182956

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
M chrome/browser/chromeos/cros/network_library.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/mobile/mobile_activator.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/dbus/mock_shill_service_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_service_client.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_service_client.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_service_client_stub.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_service_client_stub.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chromeos/network/cros_network_functions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/network/cros_network_functions.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chromeos/network/cros_network_functions_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rkc
7 years, 10 months ago (2013-02-15 21:28:09 UTC) #1
Greg Spencer (Chromium)
LGTM w/ a nit https://codereview.chromium.org/12279012/diff/1/chrome/browser/chromeos/mobile/mobile_activator.cc File chrome/browser/chromeos/mobile/mobile_activator.cc (right): https://codereview.chromium.org/12279012/diff/1/chrome/browser/chromeos/mobile/mobile_activator.cc#newcode282 chrome/browser/chromeos/mobile/mobile_activator.cc:282: // We're done with activation, ...
7 years, 10 months ago (2013-02-15 22:32:14 UTC) #2
rkc
https://codereview.chromium.org/12279012/diff/1/chrome/browser/chromeos/mobile/mobile_activator.cc File chrome/browser/chromeos/mobile/mobile_activator.cc (right): https://codereview.chromium.org/12279012/diff/1/chrome/browser/chromeos/mobile/mobile_activator.cc#newcode282 chrome/browser/chromeos/mobile/mobile_activator.cc:282: // We're done with activation, reset the cellular device. ...
7 years, 10 months ago (2013-02-15 22:53:13 UTC) #3
zel
lgtm
7 years, 10 months ago (2013-02-15 22:55:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/12279012/3001
7 years, 10 months ago (2013-02-15 22:57:25 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-16 07:54:20 UTC) #6
Message was sent while issue was closed.
Change committed as 182956

Powered by Google App Engine
This is Rietveld 408576698