Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227793003: Perf Tryjob: CSSValue refactor step 1 (Closed)

Created:
5 years, 5 months ago by sashab
Modified:
5 years, 4 months ago
Reviewers:
CC:
blink-reviews, shans, szager+layoutwatch_chromium.org, vivekg_samsung, dshwang, Manuel Rego, fs, vivekg, apavlov+blink_chromium.org, kouhei+svg_chromium.org, rwlbuis, caseq+blink_chromium.org, krit, arv+blink, Mads Ager (chromium), blink-reviews-css, blink-reviews-html_chromium.org, yurys+blink_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, kenneth.christiansen, jfernandez, rjwright, blink-reviews-style_chromium.org, zoltan1, eae+blinkwatch, sof, lushnikov+blink_chromium.org, darktears, haraken, Stephen Chennney, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, pfeldman+blink_chromium.org, f(malita), groby+blinkspell_chromium.org, svillar, oilpan-reviews, sergeyv+blink_chromium.org, kouhei+heap_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CL for perf tryjob on win

Patch Set 1 : CL for perf tryjob on win #

Patch Set 2 : CL for perf tryjob on android #

Patch Set 3 : CL for perf tryjob on win-x64 #

Patch Set 4 : CL for perf tryjob on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2684 lines, -3081 lines) Patch
M Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/StyleBuilder.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 7 chunks +33 lines, -33 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationInputHelpers.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/CSSValueInterpolationType.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/CSSValueInterpolationType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/ColorStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ColorStyleInterpolationTest.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M Source/core/animation/ConstantStyleInterpolation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DoubleStyleInterpolation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolation.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolationTest.cpp View 7 chunks +22 lines, -22 lines 0 comments Download
M Source/core/animation/FilterStyleInterpolation.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/FilterStyleInterpolationTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/ImageSliceStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ImageStyleInterpolation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/ImageStyleInterpolation.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/KeyframeEffectModelTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/KeyframeEffectTest.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolationTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/animation/LengthPairStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthPairStyleInterpolation.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/LengthPairStyleInterpolationTest.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolationTest.cpp View 8 chunks +25 lines, -24 lines 0 comments Download
M Source/core/animation/ListStyleInterpolation.h View 7 chunks +19 lines, -28 lines 0 comments Download
M Source/core/animation/ListStyleInterpolationTest.cpp View 2 chunks +22 lines, -22 lines 0 comments Download
M Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/animation/ShadowStyleInterpolation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/ShadowStyleInterpolation.cpp View 2 chunks +16 lines, -17 lines 0 comments Download
M Source/core/animation/ShadowStyleInterpolationTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/animation/StringKeyframe.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 19 chunks +53 lines, -49 lines 0 comments Download
M Source/core/animation/VisibilityStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/VisibilityStyleInterpolation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/VisibilityStyleInterpolationTest.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/core/animation/animatable/AnimatableImage.h View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableImage.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknown.h View 4 chunks +6 lines, -7 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknownTest.cpp View 1 chunk +12 lines, -22 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueTestHelper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/BasicShapeFunctions.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/BasicShapeFunctions.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/CSSBasicShapes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSBorderImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSBorderImage.cpp View 1 chunk +10 lines, -9 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCalculationValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M Source/core/css/CSSContentDistributionValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSContentDistributionValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 7 chunks +27 lines, -30 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 9 chunks +19 lines, -19 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontFeatureValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontFeatureValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSGridTemplateAreasValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSGridTemplateAreasValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageGeneratorValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSImageGeneratorValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/CSSImageValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSInheritedValue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSInitialValue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSLineBoxContainValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSLineBoxContainValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSMatrix.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSPathValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPathValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 102 chunks +102 lines, -102 lines 0 comments Download
M Source/core/css/CSSProperty.h View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSReflectValue.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSReflectValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSSVGDocumentValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSSVGDocumentValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSShadowValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSShadowValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/css/CSSTimingFunctionValue.h View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSUnicodeRangeValue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSUnsetValue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 chunk +293 lines, -189 lines 0 comments Download
D Source/core/css/CSSValue.cpp View 1 chunk +0 lines, -498 lines 0 comments Download
M Source/core/css/CSSValueList.h View 3 chunks +13 lines, -13 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 5 chunks +14 lines, -12 lines 0 comments Download
A + Source/core/css/CSSValueObject.h View 6 chunks +18 lines, -23 lines 0 comments Download
A + Source/core/css/CSSValueObject.cpp View 7 chunks +11 lines, -12 lines 0 comments Download
M Source/core/css/CSSValuePool.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A Source/core/css/CSSValueTest.cpp View 1 chunk +94 lines, -0 lines 0 comments Download
M Source/core/css/CSSValueTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 55 chunks +84 lines, -88 lines 0 comments Download
M Source/core/css/FontFace.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/FontFace.cpp View 12 chunks +37 lines, -36 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/css/StylePropertySerializer.h View 2 chunks +10 lines, -7 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 26 chunks +46 lines, -48 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 9 chunks +16 lines, -20 lines 0 comments Download
M Source/core/css/parser/CSSParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M Source/core/css/parser/CSSParserImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 4 chunks +72 lines, -72 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 139 chunks +279 lines, -279 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParserTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/parser/SizesCalcParserTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.h View 1 chunk +26 lines, -25 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 15 chunks +120 lines, -120 lines 0 comments Download
M Source/core/css/resolver/ElementStyleResources.h View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/css/resolver/ElementStyleResources.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 6 chunks +36 lines, -39 lines 0 comments Download
M Source/core/css/resolver/StyleBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 3 chunks +65 lines, -65 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 23 chunks +264 lines, -266 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 23 chunks +161 lines, -161 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/TransformBuilder.cpp View 10 chunks +54 lines, -55 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/TextLinkColors.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TextLinkColors.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 31 chunks +93 lines, -92 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 3 chunks +10 lines, -9 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLHRElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasFontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/LayoutEditor.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/LayoutEditor.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M Source/core/layout/svg/ReferenceFilterBuilder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/page/PageSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/style/StyleFetchedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/StyleFetchedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/StyleFetchedImageSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/StyleGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/StyleGeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/StyleImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/StylePendingImage.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2DState.h View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2DState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PluginPlaceholderImplTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/run-perf-test.cfg View 1 2 3 1 chunk +6 lines, -77 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sashab
CL for perf tryjob on android
5 years, 5 months ago (2015-07-09 01:10:08 UTC) #1
sashab
CL for perf tryjob on win-x64
5 years, 5 months ago (2015-07-09 01:10:47 UTC) #2
sashab
5 years, 5 months ago (2015-07-09 01:11:27 UTC) #3 
CL for perf tryjob on mac

Powered by Google App Engine
This is Rietveld 408576698