Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: ui/message_center/message_view.h

Issue 12277024: Notificaitons refactor step 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more feedback from Steven Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/message_simple_view.cc ('k') | ui/message_center/message_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/message_view.h
diff --git a/ui/message_center/message_view.h b/ui/message_center/message_view.h
index be36eb4edc6bd6ff7d9dc89c164602dbd2f4c1f0..cb6beeea1635d06d52d08e08b5086a1e301c61e1 100644
--- a/ui/message_center/message_view.h
+++ b/ui/message_center/message_view.h
@@ -34,10 +34,6 @@ class MessageView : public views::SlideOutView,
virtual ~MessageView();
- // Creates the elements that make up the view layout. Must be called
- // immediately after construction.
- virtual void SetUpView() = 0;
-
void set_scroller(views::ScrollView* scroller) { scroller_ = scroller; }
// Overridden from views::View.
@@ -60,13 +56,18 @@ class MessageView : public views::SlideOutView,
virtual void OnSlideOut() OVERRIDE;
NotificationList::Delegate* list_delegate() { return list_delegate_; }
- Notification& notification() { return notification_; }
+ const std::string& notification_id() { return notification_id_; }
+ const string16& display_source() const { return display_source_; }
+ const std::string& extension_id() const { return extension_id_; }
views::ImageButton* close_button() { return close_button_.get(); }
views::ScrollView* scroller() { return scroller_; }
private:
- NotificationList::Delegate* list_delegate_;
- Notification notification_;
+ NotificationList::Delegate* list_delegate_; // Weak, global (MessageCenter).
+ std::string notification_id_;
+ string16 display_source_;
+ std::string extension_id_;
+
scoped_ptr<views::ImageButton> close_button_;
views::ScrollView* scroller_;
« no previous file with comments | « ui/message_center/message_simple_view.cc ('k') | ui/message_center/message_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698