Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: ui/message_center/message_center_bubble.cc

Issue 12277024: Notificaitons refactor step 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more feedback from Steven Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/message_center.gyp ('k') | ui/message_center/message_center_tray_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/message_center_bubble.cc
diff --git a/ui/message_center/message_center_bubble.cc b/ui/message_center/message_center_bubble.cc
index 8cf507ad610a2c78e77364a8c2d7264f1363f0ca..141b5be8731f23ad5e3eeab29c8004e3ebdfac86 100644
--- a/ui/message_center/message_center_bubble.cc
+++ b/ui/message_center/message_center_bubble.cc
@@ -408,9 +408,8 @@ class MessageCenterContentsView : public views::View {
for (NotificationList::Notifications::const_iterator iter =
notifications.begin(); iter != notifications.end(); ++iter) {
MessageView* view =
- NotificationView::ViewForNotification(*iter, list_delegate_);
+ NotificationView::ViewForNotification(*(*iter), list_delegate_);
view->set_scroller(scroller_);
- view->SetUpView();
if (IsRichNotificationEnabled())
view->set_border(new MessageViewShadowBorder());
scroll_content_->AddChildView(view);
@@ -508,8 +507,8 @@ void MessageCenterBubble::OnBubbleViewDestroyed() {
void MessageCenterBubble::UpdateBubbleView() {
if (!bubble_view())
return; // Could get called after view is closed
- NotificationList::Notifications notifications;
- list_delegate()->GetNotificationList()->GetNotifications(&notifications);
+ const NotificationList::Notifications& notifications =
+ list_delegate()->GetNotificationList()->GetNotifications();
contents_view_->Update(notifications);
bubble_view()->Show();
bubble_view()->UpdateBubble();
« no previous file with comments | « ui/message_center/message_center.gyp ('k') | ui/message_center/message_center_tray_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698