git_cl.py - Issue 12276007: Add patchset number on manual commit comment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 12276007: Add patchset number on manual commit comment. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: fix nits Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 6085aba94ef8dea2884c3d1284f66f2545e52087..e515f89b00eaed6cd09da7ee90990e2db48b0d90 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -1495,7 +1495,9 @@ def SendUpstream(parser, args, cmd):

print ('Closing issue '

'(you may be prompted for your codereview password)...')

cl.CloseIssue()

- comment = "Committed manually as r%s" % revision

+ props = cl.RpcServer().get_issue_properties(cl.GetIssue())

+ patch_num = len(props['patchset'])

+ comment = "Committed patchset #%d manually as r%s" % (patch_num, revision)

comment += ' (presubmit successful).' if not options.bypass_hooks else '.'

cl.RpcServer().add_comment(cl.GetIssue(), comment)

cl.SetIssue(0)

« no previous file with comments | « gcl.py ('k') | tests/gcl_unittest.py » ('j') | no next file with comments »