Add patchset number on manual commit comment.

Add patchset number on manual commit comment.

R=cmp@chromium.org, maruel@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=182861

[iannucci, 2013-02-15 22:23:15]

PTAL.

[M-A Ruel, 2013-02-15 22:43:34]

lgtm with changes

https://codereview.chromium.org/12276007/diff/1/gcl.py
File gcl.py (right):

https://codereview.chromium.org/12276007/diff/1/gcl.py#newcode1053
gcl.py:1053: patch_num = len(change_info.GetIssueProperties()['patchsets'])
I'd be fine with:
change_info.RpcServer().get_issue_properties(change_info.issue)

That's save you from a new function that will never be reused.

https://codereview.chromium.org/12276007/diff/1/gcl.py#newcode1054
gcl.py:1054: comment = "Committed patch #%d manually as r%s" % (patch_num,
revision)
s/patch/patchset/

https://codereview.chromium.org/12276007/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/12276007/diff/1/git_cl.py#newcode1500
git_cl.py:1500: comment = "Committed patch #%d manually as r%s" % (patch_num,
revision)
s/patch/patchset/

[iannucci, 2013-02-15 23:09:00]

https://codereview.chromium.org/12276007/diff/1/gcl.py
File gcl.py (right):

https://codereview.chromium.org/12276007/diff/1/gcl.py#newcode1053
gcl.py:1053: patch_num = len(change_info.GetIssueProperties()['patchsets'])
On 2013/02/15 22:43:34, Marc-Antoine Ruel wrote:
> I'd be fine with:
> change_info.RpcServer().get_issue_properties(change_info.issue)
> 
> That's save you from a new function that will never be reused.

Done. (Though it made the test a little (more) awkward :))

https://codereview.chromium.org/12276007/diff/1/gcl.py#newcode1054
gcl.py:1054: comment = "Committed patch #%d manually as r%s" % (patch_num,
revision)
On 2013/02/15 22:43:34, Marc-Antoine Ruel wrote:
> s/patch/patchset/

Done.

https://codereview.chromium.org/12276007/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/12276007/diff/1/git_cl.py#newcode1500
git_cl.py:1500: comment = "Committed patch #%d manually as r%s" % (patch_num,
revision)
On 2013/02/15 22:43:34, Marc-Antoine Ruel wrote:
> s/patch/patchset/

Done.

[M-A Ruel, 2013-02-15 23:12:08]

https://codereview.chromium.org/12276007/diff/1/gcl.py
File gcl.py (right):

https://codereview.chromium.org/12276007/diff/1/gcl.py#newcode1053
gcl.py:1053: patch_num = len(change_info.GetIssueProperties()['patchsets'])
On 2013/02/15 23:09:00, iannucci wrote:
> On 2013/02/15 22:43:34, Marc-Antoine Ruel wrote:
> > I'd be fine with:
> > change_info.RpcServer().get_issue_properties(change_info.issue)
> > 
> > That's save you from a new function that will never be reused.
> 
> Done. (Though it made the test a little (more) awkward :))

As you prefer

[iannucci, 2013-02-15 23:16:52]

On 2013/02/15 23:12:08, Marc-Antoine Ruel wrote:
> https://codereview.chromium.org/12276007/diff/1/gcl.py
> File gcl.py (right):
> 
> https://codereview.chromium.org/12276007/diff/1/gcl.py#newcode1053
> gcl.py:1053: patch_num = len(change_info.GetIssueProperties()['patchsets'])
> On 2013/02/15 23:09:00, iannucci wrote:
> > On 2013/02/15 22:43:34, Marc-Antoine Ruel wrote:
> > > I'd be fine with:
> > > change_info.RpcServer().get_issue_properties(change_info.issue)
> > > 
> > > That's save you from a new function that will never be reused.
> > 
> > Done. (Though it made the test a little (more) awkward :))
> 
> As you prefer

More concise mainline code == better, imo. committing as-is.

[commit-bot: I haz the power, 2013-02-15 23:19:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/12276007/2002

[commit-bot: I haz the power, 2013-02-15 23:22:06]

Change committed as 182861