go/src/infra/gae/libs/gae/filters/count/count_test.go - Issue 1227203004: Convert 'Testable' interface into an optional filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/src/infra/gae/libs/gae/filters/count/count_test.go

Issue 1227203004: Convert 'Testable' interface into an optional filter. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@add_filters

Patch Set: final rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « go/src/infra/gae/libs/gae/brokenfeatures_test.go ('k') | go/src/infra/gae/libs/gae/filters/featureBreaker/featureBreaker.infra_testing » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: go/src/infra/gae/libs/gae/filters/count/count_test.go

diff --git a/go/src/infra/gae/libs/gae/filters/count/count_test.go b/go/src/infra/gae/libs/gae/filters/count/count_test.go

index d57a34c4df1f567cb35c12a39d43924f52b34343..f8950c745d0e5602e98d94fc00bb48033de23e3b 100644

--- a/go/src/infra/gae/libs/gae/filters/count/count_test.go

+++ b/go/src/infra/gae/libs/gae/filters/count/count_test.go

@@ -10,6 +10,7 @@ import (

"testing"

"infra/gae/libs/gae"

+ "infra/gae/libs/gae/filters/featureBreaker"

"infra/gae/libs/gae/memory"

. "github.com/smartystreets/goconvey/convey"

@@ -98,13 +99,15 @@ func TestCount(t *testing.T) {

})

Convey("works for global info", t, func() {

- c, ctr := FilterGI(memory.Use(context.Background()))

+ c, fb := featureBreaker.FilterGI(memory.Use(context.Background()), nil)

+ c, ctr := FilterGI(c)

So(c, ShouldNotBeNil)

So(ctr, ShouldNotBeNil)

gi := gae.GetGI(c)

gi.Namespace("foo")

- gae.GetGIUnfiltered(c).(gae.Testable).BreakFeatures(nil, "Namespace")

+ fb.BreakFeatures(nil, "Namespace")

gi.Namespace("boom")

So(ctr.Namespace, ShouldResemble, Entry{1, 1})