Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: go/src/infra/gae/libs/gae/memory/plist_test.go

Issue 1227183003: Change RawDatastore to do less reflection. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@move_dummy
Patch Set: fix No/ShouldIndex Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « go/src/infra/gae/libs/gae/memory/plist.go ('k') | go/src/infra/gae/libs/gae/memory/raw_datstore.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/gae/libs/gae/memory/plist_test.go
diff --git a/go/src/infra/gae/libs/gae/memory/plist_test.go b/go/src/infra/gae/libs/gae/memory/plist_test.go
index 592b60061d58def873b3ed8c46c02903d1af7517..050919a457a65dba2401399465b8062628728d4a 100644
--- a/go/src/infra/gae/libs/gae/memory/plist_test.go
+++ b/go/src/infra/gae/libs/gae/memory/plist_test.go
@@ -48,9 +48,9 @@ func TestCollated(t *testing.T) {
Convey("list", func() {
pm := gae.DSPropertyMap{
- "wat": {prop("thing", true), prop("hat"), prop(100)},
+ "wat": {propNI("thing"), prop("hat"), prop(100)},
"nerd": {prop(103.7)},
- "spaz": {prop(false, true)},
+ "spaz": {propNI(false)},
}
sip := partiallySerialize(pm)
So(len(sip), ShouldEqual, 2)
@@ -102,9 +102,9 @@ var rowGenTestCases = []struct {
{
name: "simple including builtins",
pmap: gae.DSPropertyMap{
- "wat": {prop("thing", true), prop("hat"), prop(100)},
+ "wat": {propNI("thing"), prop("hat"), prop(100)},
"nerd": {prop(103.7)},
- "spaz": {prop(false, true)},
+ "spaz": {propNI(false)},
},
withBuiltin: true,
idxs: []*qIndex{
« no previous file with comments | « go/src/infra/gae/libs/gae/memory/plist.go ('k') | go/src/infra/gae/libs/gae/memory/raw_datstore.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698