Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1776)

Issue 1226373010: Roll android_tools repo. (Closed)

Created:
5 years, 5 months ago by aurimas (slooooooooow)
Modified:
5 years, 5 months ago
Reviewers:
Yaron, jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll android_tools repo. - Roll to Android Support Library 22.2.1 - Add gyp target for multidex support library. - Revert the workaround for KEYCODE_MENU as 22.2.1 has the bug for it again. BUG=510128, 272790 TBR=yfriedman@chromium.org Committed: https://crrev.com/eb3e372e3ac34f2d29dc5d544b2a4350d2cf775a Cr-Commit-Position: refs/heads/master@{#339729}

Patch Set 1 #

Patch Set 2 : Revert MENU workaround #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 1 4 chunks +16 lines, -0 lines 0 comments Download
M base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java View 1 3 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
aurimas (slooooooooow)
PTAL
5 years, 5 months ago (2015-07-17 22:59:40 UTC) #2
jbudorick
lgtm
5 years, 5 months ago (2015-07-17 23:06:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226373010/1
5 years, 5 months ago (2015-07-17 23:08:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/45934)
5 years, 5 months ago (2015-07-18 01:52:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226373010/1
5 years, 5 months ago (2015-07-20 22:46:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/46453)
5 years, 5 months ago (2015-07-21 01:19:13 UTC) #11
aurimas (slooooooooow)
TBR yfriedman@chromium.org
5 years, 5 months ago (2015-07-21 18:43:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226373010/20001
5 years, 5 months ago (2015-07-21 18:44:35 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 20:16:53 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 20:18:01 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb3e372e3ac34f2d29dc5d544b2a4350d2cf775a
Cr-Commit-Position: refs/heads/master@{#339729}

Powered by Google App Engine
This is Rietveld 408576698