Issue 12263031: Enable weak embedded maps in optimized code by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12263031: Enable weak embedded maps in optimized code by default. (Closed)

Created:
7 years, 10 months ago by ulan

Modified:
7 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Enable weak embedded maps in optimized code by default. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13666

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/flag-definitions.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. The "true" looks to be written correctly, so I have confidence that this change ...

7 years, 10 months ago (2013-02-14 10:06:04 UTC) #2

ulan

7 years, 10 months ago (2013-02-14 10:09:18 UTC) #3

Message was sent while issue was closed.

On 2013/02/14 10:06:04, Michael Starzinger wrote:
> LGTM. The "true" looks to be written correctly, so I have confidence that this
> change is correct. :)

Thanks, landed. I was worried that this might cause crashes on canary, but now
you convinced me otherwise. :)

Expand Messages | Collapse Messages