Android: Add test runner scripts to run content_browsertests.

Android: Add test runner scripts to run content_browsertests.

We want to run only one testcase each time the test activity is invoked.

Next:
Currently the APK is reinstalled before runnning each test case, avoiding that (and other test data setup) will speed up tests a lot.

build/android/run_browser_tests.py  -vvv -f SessionHistoryTest.BasicBackForward:SessionHistoryTest.FrameBackForward
BUG=138275
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183982

[nilesh, 2013-02-15 01:47:40]

+craigdh

[frankf, 2013-02-15 02:10:02]

Currently, there's little difference between browser_tests test_runner/sharder
and existing gtests except some constant parameters. Can you just inherit from
those instead of base?

Also, craigdh has started a refactoring of base sharder/runner
(crbug.com/176325). I don't think this CL should necessarily be blocked, but
keeping new code to a minimum by inheriting should make his life easier.

https://codereview.chromium.org/12263024/diff/2002/build/android/run_browser_...
File build/android/run_browser_tests.py (right):

https://codereview.chromium.org/12263024/diff/2002/build/android/run_browser_...
build/android/run_browser_tests.py:24: def _RunContentBrowserTestSuite(options):
Let's move this to browsertests.dispatch similar to other tests.

https://codereview.chromium.org/12263024/diff/7002/build/android/pylib/browse...
File build/android/pylib/browsertests/test_runner.py (right):

https://codereview.chromium.org/12263024/diff/7002/build/android/pylib/browse...
build/android/pylib/browsertests/test_runner.py:57:
'content-browser-tests-command-line')
Define these in constants.py

https://codereview.chromium.org/12263024/diff/7002/build/android/pylib/gtest/...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/12263024/diff/7002/build/android/pylib/gtest/...
build/android/pylib/gtest/test_runner.py:170:
'chrome-native-tests-command-line')
Let's define this in constants.py

[nilesh, 2013-02-20 18:23:31]

Got rid of the custom test_runner.
The sharder will go away one I merge with Craig's sharder CL.
PTAL.

On 2013/02/15 02:10:02, frankf wrote:
> Currently, there's little difference between browser_tests test_runner/sharder
> and existing gtests except some constant parameters. Can you just inherit from
> those instead of base?
> 
> Also, craigdh has started a refactoring of base sharder/runner
> (crbug.com/176325). I don't think this CL should necessarily be blocked, but
> keeping new code to a minimum by inheriting should make his life easier.
> 
>

[nilesh, 2013-02-20 18:23:36]

https://codereview.chromium.org/12263024/diff/7002/build/android/pylib/browse...
File build/android/pylib/browsertests/test_runner.py (right):

https://codereview.chromium.org/12263024/diff/7002/build/android/pylib/browse...
build/android/pylib/browsertests/test_runner.py:57:
'content-browser-tests-command-line')
On 2013/02/15 02:10:02, frankf wrote:
> Define these in constants.py

Done.

https://codereview.chromium.org/12263024/diff/7002/build/android/pylib/gtest/...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/12263024/diff/7002/build/android/pylib/gtest/...
build/android/pylib/gtest/test_runner.py:170:
'chrome-native-tests-command-line')
On 2013/02/15 02:10:02, frankf wrote:
> Let's define this in constants.py

Done.

[craigdh, 2013-02-20 23:45:30]

fyi, I've landed the new sharder. Sorry to have all this churn in the middle of
your cl, but things should be stable now.

https://codereview.chromium.org/12263024/diff/20001/build/android/pylib/brows...
File build/android/pylib/browsertests/dispatch.py (right):

https://codereview.chromium.org/12263024/diff/20001/build/android/pylib/brows...
build/android/pylib/browsertests/dispatch.py:26: if options.gtest_filter:
You won't need this after merging with the new sharder.

[nilesh, 2013-02-21 00:12:15]

Rebased: Added support for GetAllTests and sharding. Updated description.
 
Please take another look.

[craigdh, 2013-02-21 00:26:02]

https://codereview.chromium.org/12263024/diff/20002/build/android/pylib/brows...
File build/android/pylib/browsertests/dispatch.py (right):

https://codereview.chromium.org/12263024/diff/20002/build/android/pylib/brows...
build/android/pylib/browsertests/dispatch.py:29: if options.gtest_filter:
This isn't needed.

https://codereview.chromium.org/12263024/diff/20002/build/android/pylib/gtest...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/12263024/diff/20002/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:152: test_apk_package_name: Apk package
name for tests running in APKs.
Maybe create a struct-looking class that just holds these three fields as they
are associated and passed together everywhere.

https://codereview.chromium.org/12263024/diff/20002/build/android/run_browser...
File build/android/run_browser_tests.py (right):

https://codereview.chromium.org/12263024/diff/20002/build/android/run_browser...
build/android/run_browser_tests.py:3: # Copyright (c) 2013 The Chromium Authors.
All rights reserved.
There was just a thread on chromium-dev, apparently we don't include the (c) any
more.

[nilesh, 2013-02-21 18:04:13]

https://codereview.chromium.org/12263024/diff/20002/build/android/pylib/brows...
File build/android/pylib/browsertests/dispatch.py (right):

https://codereview.chromium.org/12263024/diff/20002/build/android/pylib/brows...
build/android/pylib/browsertests/dispatch.py:29: if options.gtest_filter:
On 2013/02/21 00:26:02, craigdh wrote:
> This isn't needed.
Removed.

https://codereview.chromium.org/12263024/diff/20002/build/android/pylib/gtest...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/12263024/diff/20002/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:152: test_apk_package_name: Apk package
name for tests running in APKs.
On 2013/02/21 00:26:02, craigdh wrote:
> Maybe create a struct-looking class that just holds these three fields as they
> are associated and passed together everywhere.

As discussed offline, I will keep the arguments separate for now.

https://codereview.chromium.org/12263024/diff/20002/build/android/run_browser...
File build/android/run_browser_tests.py (right):

https://codereview.chromium.org/12263024/diff/20002/build/android/run_browser...
build/android/run_browser_tests.py:3: # Copyright (c) 2013 The Chromium Authors.
All rights reserved.
On 2013/02/21 00:26:02, craigdh wrote:
> There was just a thread on chromium-dev, apparently we don't include the (c)
any
> more.

Done.

[craigdh, 2013-02-21 18:05:47]

lgtm.

[frankf, 2013-02-21 19:25:50]

lgtm with nits.

https://codereview.chromium.org/12263024/diff/28001/build/android/pylib/brows...
File build/android/pylib/browsertests/dispatch.py (right):

https://codereview.chromium.org/12263024/diff/28001/build/android/pylib/brows...
build/android/pylib/browsertests/dispatch.py:16: CONTENT_BROWSERTEST_SUITENAME =
'content_browsertests'
2 blank lines. Please run gpylint.

https://codereview.chromium.org/12263024/diff/28001/build/android/pylib/gtest...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/12263024/diff/28001/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:160: command_line_file):
These paramters are not required for test_package_executables. Should they be
optional then?

[nilesh, 2013-02-21 20:10:17]

https://codereview.chromium.org/12263024/diff/28001/build/android/pylib/brows...
File build/android/pylib/browsertests/dispatch.py (right):

https://codereview.chromium.org/12263024/diff/28001/build/android/pylib/brows...
build/android/pylib/browsertests/dispatch.py:16: CONTENT_BROWSERTEST_SUITENAME =
'content_browsertests'
On 2013/02/21 19:25:50, frankf wrote:
> 2 blank lines. Please run gpylint.

Done.

https://codereview.chromium.org/12263024/diff/28001/build/android/pylib/gtest...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/12263024/diff/28001/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:160: command_line_file):
On 2013/02/21 19:25:50, frankf wrote:
> These paramters are not required for test_package_executables. Should they be
> optional then?

Done.

[commit-bot: I haz the power, 2013-02-21 22:29:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12263024/22002

[commit-bot: I haz the power, 2013-02-22 02:26:16]

Change committed as 183982