Issue 12263006: Fixed portal detector behaviour for proxied network.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12263006: Fixed portal detector behaviour for proxied network. (Closed)

Created:
7 years, 10 months ago by ygorshenin1

Modified:
7 years, 10 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed portal detector behaviour for proxied network. Active network is marked as PROXY_AUTH_REQUIRED only after 3 consecutive failing attempts. This gives enough time for the network stack to connect to the proxied network after proxy authenication. BUG=174061 TEST=unit_tests:NetworkPortalDetectorTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182385

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -7 lines)			Patch
	M	chrome/browser/chromeos/net/network_portal_detector.cc	View		2 chunks	+6 lines, -7 lines	0 comments	Download
	M	chrome/browser/chromeos/net/network_portal_detector_unittest.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/12263006/1

7 years, 10 months ago (2013-02-13 20:13:27 UTC) #4

Message was sent while issue was closed.

Change committed as 182385

Expand Messages | Collapse Messages