Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12262027: Fixed privacy issues in USB printer detection on Chrome OS. (Closed)

Created:
7 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 10 months ago
Reviewers:
keybuk
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fixed privacy issues in USB printer detection on Chrome OS. Don't send vendor/product ids. Use HTTPS. Don't open page if screen locked. BUG=176145 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M chrome/browser/chromeos/dbus/printer_service_provider.cc View 3 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Vitaly Buka (NO REVIEWS)
Scott, please review this changes.
7 years, 10 months ago (2013-02-13 23:31:31 UTC) #1
keybuk
lgtm
7 years, 10 months ago (2013-02-13 23:37:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12262027/1
7 years, 10 months ago (2013-02-13 23:52:43 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) aura_unittests, browser_tests, compositor_unittests, content_browsertests, content_unittests, interactive_ui_tests, ...
7 years, 10 months ago (2013-02-14 00:10:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12262027/1
7 years, 10 months ago (2013-02-14 00:16:17 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) aura_unittests, browser_tests, compositor_unittests, content_browsertests, content_unittests, interactive_ui_tests, ...
7 years, 10 months ago (2013-02-14 00:59:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12262027/1
7 years, 10 months ago (2013-02-14 01:11:58 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests, nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=98833
7 years, 10 months ago (2013-02-14 01:32:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12262027/1
7 years, 10 months ago (2013-02-14 02:04:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12262027/1
7 years, 10 months ago (2013-02-14 09:23:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12262027/1
7 years, 10 months ago (2013-02-14 09:25:24 UTC) #11
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 09:25:33 UTC) #12
Message was sent while issue was closed. 
Change committed as 182430

Powered by Google App Engine
This is Rietveld 408576698