Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 12262025: Alter the ActivityLog db table schemas. (Closed)

Created:
7 years, 10 months ago by felt
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Alter the ActivityLog db table schemas. Remove some arguments from LogDOMAction. Rename URIAction to DOMAction. Make sure db operations will be OK if we add new columns to tables. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -370 lines) Patch
M chrome/browser/extensions/activity_actions.h View 2 chunks +10 lines, -0 lines 0 comments Download
A chrome/browser/extensions/activity_actions.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_database.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/activity_database.cc View 3 chunks +3 lines, -18 lines 0 comments Download
M chrome/browser/extensions/activity_database_unittest.cc View 5 chunks +47 lines, -6 lines 0 comments Download
M chrome/browser/extensions/activity_log.h View 4 chunks +26 lines, -6 lines 0 comments Download
M chrome/browser/extensions/activity_log.cc View 4 chunks +112 lines, -79 lines 0 comments Download
M chrome/browser/extensions/activity_log_unittest.cc View 5 chunks +11 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api_actions.h View 4 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api_actions.cc View 6 chunks +15 lines, -30 lines 0 comments Download
M chrome/browser/extensions/blocked_actions.h View 3 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/extensions/blocked_actions.cc View 3 chunks +35 lines, -12 lines 0 comments Download
A chrome/browser/extensions/dom_actions.h View 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/browser/extensions/dom_actions.cc View 1 chunk +133 lines, -0 lines 0 comments Download
D chrome/browser/extensions/url_actions.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/extensions/url_actions.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
felt
Matt-- this is a duplicate of https://codereview.chromium.org/12207060/, to try to fix the patch problem.
7 years, 10 months ago (2013-02-13 23:23:13 UTC) #1
Matt Perry
lgtm
7 years, 10 months ago (2013-02-13 23:32:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/12262025/1
7 years, 10 months ago (2013-02-14 04:38:54 UTC) #3
commit-bot: I haz the power
Presubmit check for 12262025-1 failed and returned exit status 1. INFO:root:Found 15 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-14 04:39:09 UTC) #4
felt
Ben -- need OWNERS approval for adding new files to chrome/chrome_browser_extensions.gypi.
7 years, 10 months ago (2013-02-14 04:46:26 UTC) #5
Ben Goodger (Google)
lgtm you can tbr gyp changes
7 years, 10 months ago (2013-02-14 23:18:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/12262025/1
7 years, 10 months ago (2013-02-14 23:21:45 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-15 04:57:08 UTC) #8
Message was sent while issue was closed.
Change committed as 182618

Powered by Google App Engine
This is Rietveld 408576698