Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12262016: Adding IME test changes to make it easier to test. (Closed)

Created:
7 years, 10 months ago by aurimas (slooooooooow)
Modified:
7 years, 10 months ago
Reviewers:
Ted C, Yusuf
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Adding IME test changes to make it easier to test. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182344

Patch Set 1 #

Patch Set 2 : Disabling Tests temporarily #

Total comments: 4

Patch Set 3 : Fixed Ted's nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -22 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 5 chunks +10 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java View 1 2 4 chunks +12 lines, -10 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ImeTest.java View 1 4 chunks +161 lines, -10 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aurimas (slooooooooow)
PTAL
7 years, 10 months ago (2013-02-13 22:07:50 UTC) #1
Ted C
lgtm w/ nits https://codereview.chromium.org/12262016/diff/1001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java File content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java (right): https://codereview.chromium.org/12262016/diff/1001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java#newcode283 content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:283: boolean checkCompositionQueueAndCallNative(String text, int newCursorPosition, @VisibleForTesting ...
7 years, 10 months ago (2013-02-13 22:17:56 UTC) #2
aurimas (slooooooooow)
https://codereview.chromium.org/12262016/diff/1001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java File content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java (right): https://codereview.chromium.org/12262016/diff/1001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java#newcode283 content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:283: boolean checkCompositionQueueAndCallNative(String text, int newCursorPosition, On 2013/02/13 22:17:56, Ted ...
7 years, 10 months ago (2013-02-13 22:27:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/12262016/2006
7 years, 10 months ago (2013-02-13 22:31:50 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, chromeos_unittests, ...
7 years, 10 months ago (2013-02-13 23:00:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/12262016/2006
7 years, 10 months ago (2013-02-13 23:44:43 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 23:57:51 UTC) #7
Message was sent while issue was closed. 
Change committed as 182344

Powered by Google App Engine
This is Rietveld 408576698