Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 12261058: build: Remove deprecated 'library' variable from common.gypi. (Closed)

Created:
7 years, 10 months ago by tfarina
Modified:
7 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

build: Remove deprecated 'library' variable from common.gypi. Looks like all the third_party usages were fixed. BUG=111541 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Lets see what the trybots has to say to us. Locally it passed.
7 years, 10 months ago (2013-02-15 14:18:35 UTC) #1
Nico
lgtm! :-)
7 years, 10 months ago (2013-02-18 10:08:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12261058/1
7 years, 10 months ago (2013-02-18 15:05:56 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-18 22:21:19 UTC) #4
Message was sent while issue was closed.
Change committed as 183142

Powered by Google App Engine
This is Rietveld 408576698