Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: chrome/browser/translate/options_menu_model.cc

Issue 12261053: Translate: enable bad language detection reports for secure pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/options_menu_model.cc
diff --git a/chrome/browser/translate/options_menu_model.cc b/chrome/browser/translate/options_menu_model.cc
index e00d8ef695541099914200783790d99e906a8e3e..a289364a70ede92b19388e1423527d38d0b58255 100644
--- a/chrome/browser/translate/options_menu_model.cc
+++ b/chrome/browser/translate/options_menu_model.cc
@@ -85,18 +85,6 @@ bool OptionsMenuModel::IsCommandIdEnabled(int command_id) const {
return (!translate_infobar_delegate_->IsLanguageBlacklisted() &&
!translate_infobar_delegate_->IsSiteBlacklisted());
- case IDC_TRANSLATE_REPORT_BAD_LANGUAGE_DETECTION : {
- // Until we have a secure URL for reporting language detection errors,
- // we don't report errors that happened on secure URLs.
- DCHECK(translate_infobar_delegate_ != NULL);
- DCHECK(translate_infobar_delegate_->owner() != NULL);
- DCHECK(translate_infobar_delegate_->owner()->GetWebContents() != NULL);
- NavigationEntry* entry = translate_infobar_delegate_->owner()->
- GetWebContents()->GetController().GetActiveEntry();
- // Delegate and tab contents should never be NULL, but active entry
- // can be NULL when running tests. We want to return false if NULL.
- return (entry != NULL) && !entry->GetURL().SchemeIsSecure();
- }
default:
break;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698