Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: chrome/browser/resources/file_manager/js/photo/gallery_testapi.js

Issue 12261004: [Cleanup] Files.app: Remove 'this' from class methods. #2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/file_manager/js/media/player_testapi.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/js/photo/gallery_testapi.js
diff --git a/chrome/browser/resources/file_manager/js/photo/gallery_testapi.js b/chrome/browser/resources/file_manager/js/photo/gallery_testapi.js
index a543b0c0e50ce1eabbb582e326b5ffcf7c8659e6..856e5f529690ed64dd154f5f7ec9fc30bfab7a28 100644
--- a/chrome/browser/resources/file_manager/js/photo/gallery_testapi.js
+++ b/chrome/browser/resources/file_manager/js/photo/gallery_testapi.js
@@ -22,53 +22,53 @@ var galleryTestAPI = {
*/
load: function(path) {
Gallery.openStandalone(path, null, function() {
- this.waitFor_('loaded');
- }.bind(this));
+ galleryTestAPI.waitFor_('loaded');
+ });
},
/**
* Responds with the selected file name.
*/
getSelectedFileName: function() {
- this.respond_(document.querySelector('.namebox').value);
+ galleryTestAPI.respond_(document.querySelector('.namebox').value);
},
/**
* Toggles edit mode.
*/
clickEditToggle: function() {
- this.click('.edit');
- setTimeout(this.respond_.bind(this, true), 0);
+ galleryTestAPI.click('.edit');
+ setTimeout(galleryTestAPI.respond_.bind(null, true), 0);
},
/**
* Clicks arrow to select next image.
*/
clickNextImageArrow: function() {
- this.click('.arrow.right');
- this.waitFor_('image-displayed');
+ galleryTestAPI.click('.arrow.right');
+ galleryTestAPI.waitFor_('image-displayed');
},
/**
* Clicks arrow to select previous image.
*/
clickPreviousImageArrow: function() {
- this.click('.arrow.left');
- this.waitFor_('image-displayed');
+ galleryTestAPI.click('.arrow.left');
+ galleryTestAPI.waitFor_('image-displayed');
},
/**
* Clicks last thumbnail in ribbon to select an image.
*/
clickLastRibbonThumbnail: function() {
- this.clickRibbonThumbnail(true);
+ galleryTestAPI.clickRibbonThumbnail(true);
},
/**
* Clicks first thumbnail in ribbon to select an image.
*/
clickFirstRibbonThumbnail: function() {
- this.clickRibbonThumbnail(false);
+ galleryTestAPI.clickRibbonThumbnail(false);
},
/**
@@ -80,54 +80,57 @@ var galleryTestAPI = {
setTimeout(function() {
var nodes = document.querySelectorAll('.ribbon > :not([vanishing])');
if (nodes.length == 0) {
- this.respond_(false);
+ galleryTestAPI.respond_(false);
return;
}
nodes[last ? nodes.length - 1 : 0].click();
- this.waitFor_('image-displayed');
- }.bind(this), 0);
+ galleryTestAPI.waitFor_('image-displayed');
+ }, 0);
},
/**
* Clicks 'rotate left' tool.
*/
clickRotateLeft: function() {
- this.editAndRespond_(this.click.bind(this, '.rotate_left'));
+ galleryTestAPI.editAndRespond_(
+ galleryTestAPI.click.bind(null, '.rotate_left'));
},
/**
* Clicks 'rotate right' tool.
*/
clickRotateRight: function() {
- this.editAndRespond_(this.click.bind(this, '.rotate_right'));
+ galleryTestAPI.editAndRespond_(
+ galleryTestAPI.click.bind(null, '.rotate_right'));
},
/**
* Clicks 'undo' tool.
*/
clickUndo: function() {
- this.editAndRespond_(this.click.bind(this, '.undo'));
+ galleryTestAPI.editAndRespond_(galleryTestAPI.click.bind(null, '.undo'));
},
/**
* Clicks 'redo' tool.
*/
clickRedo: function() {
- this.editAndRespond_(this.click.bind(this, '.redo'));
+ galleryTestAPI.editAndRespond_(galleryTestAPI.click.bind(null, '.redo'));
},
/**
* Clicks 'autofix' tool.
*/
clickAutofix: function() {
- this.editAndRespond_(this.click.bind(this, '.autofix'));
+ galleryTestAPI.editAndRespond_(galleryTestAPI.click.bind(null, '.autofix'));
},
/**
* Responds whether autofix tool is available.
*/
isAutofixAvailable: function() {
- this.respond_(!document.querySelector('.autofix').hasAttribute('disabled'));
+ galleryTestAPI.respond_(
+ !document.querySelector('.autofix').hasAttribute('disabled'));
},
/**
@@ -147,19 +150,19 @@ var galleryTestAPI = {
// TODO(dgozman): investigate why this is required sometimes.
setTimeout(function() {
action();
- this.waitFor_('image-saved');
- }.bind(this), 0);
+ galleryTestAPI.waitFor_('image-saved');
+ }, 0);
},
/**
* Waits for event fired and then calls a function.
* @param {string} event Event name.
* @param {function=} opt_callback Callback. If not passed,
- * |this.respond_(true)| is called.
+ * |galleryTestAPI.respond_(true)| is called.
* @private
*/
waitFor_: function(event, opt_callback) {
- var callback = opt_callback || this.respond_.bind(this, true);
+ var callback = opt_callback || galleryTestAPI.respond_.bind(null, true);
var listener = function() {
Gallery.instance.removeEventListener(event, listener);
callback();
@@ -174,8 +177,8 @@ var galleryTestAPI = {
respond_: function(value) {
if (window.domAutomationController) {
window.domAutomationController.send(value);
- } else if (this.respondCallback) {
- this.respondCallback(value);
+ } else if (galleryTestAPI.respondCallback) {
+ galleryTestAPI.respondCallback(value);
} else {
console.log('playerTestAPI response: ' + value);
}
« no previous file with comments | « chrome/browser/resources/file_manager/js/media/player_testapi.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698