Issue 12261003: Possible solution to synchronization problems in webrtc audio capturer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12261003: Possible solution to synchronization problems in webrtc audio capturer. (Closed)

Created:
7 years, 10 months ago by phoglund_chromium

Modified:
7 years, 10 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Possible solution to synchronization problems in webrtc audio capturer. Re-land of https://codereview.chromium.org/12220063/. This will hold on to a reference to the buffer while the buffer is being used by WebRTC. I also tried to fix the places where synchronization was missing (mostly for the params_ instance). BUG=173987 TBR=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182227

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -48 lines)			Patch
M	content/renderer/media/webrtc_audio_capturer.h	View	3 chunks	+13 lines, -7 lines	0 comments	Download
M	content/renderer/media/webrtc_audio_capturer.cc	View	9 chunks	+95 lines, -40 lines	0 comments	Download
M	content/renderer/media/webrtc_local_audio_renderer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/12261003/1

7 years, 10 months ago (2013-02-13 12:28:52 UTC) #1

Message was sent while issue was closed.

Change committed as 182227