Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: ash/system/tray/system_tray_unittest.cc

Issue 12260046: Show notification when activating with no connection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix logic and type icon Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/tray/system_tray.cc ('k') | chrome/app/chromeos_strings.grdp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/tray/system_tray_unittest.cc
diff --git a/ash/system/tray/system_tray_unittest.cc b/ash/system/tray/system_tray_unittest.cc
index 74da62510a4c730e02a6306f98d2f3f4315cc36f..9b62f275283f971af7cf227a5a35c98d7313209e 100644
--- a/ash/system/tray/system_tray_unittest.cc
+++ b/ash/system/tray/system_tray_unittest.cc
@@ -232,12 +232,12 @@ TEST_F(SystemTrayTest, SystemTrayNotifications) {
tray->ShowNotificationView(test_item);
ASSERT_TRUE(test_item->notification_view() != NULL);
- // Show the default view, ensure the notification view is destroyed.
+ // Show the default view, notification view should remain.
tray->ShowDefaultView(BUBBLE_CREATE_NEW);
RunAllPendingInMessageLoop();
- ASSERT_TRUE(test_item->notification_view() == NULL);
+ ASSERT_TRUE(test_item->notification_view() != NULL);
- // Show the detailed view, ensure the notificaiton view is created again.
+ // Show the detailed view, ensure the notificaiton view remains.
tray->ShowDetailedView(detailed_item, 0, false, BUBBLE_CREATE_NEW);
RunAllPendingInMessageLoop();
ASSERT_TRUE(detailed_item->detailed_view() != NULL);
« no previous file with comments | « ash/system/tray/system_tray.cc ('k') | chrome/app/chromeos_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698