Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4548)

Unified Diff: ash/system/chromeos/network/tray_sms.cc

Issue 12260046: Show notification when activating with no connection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/system/tray/system_tray.cc » ('j') | chrome/browser/ui/ash/chrome_shell_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/chromeos/network/tray_sms.cc
diff --git a/ash/system/chromeos/network/tray_sms.cc b/ash/system/chromeos/network/tray_sms.cc
index 588cd4f49be08cd26240c01bb6da761b99b37f24..5814eb8913e533f25774ecd38aba4fdf656b75ab 100644
--- a/ash/system/chromeos/network/tray_sms.cc
+++ b/ash/system/chromeos/network/tray_sms.cc
@@ -302,12 +302,15 @@ views::View* TraySms::CreateDetailedView(user::LoginStatus status) {
HideNotificationView();
if (messages_.empty())
return NULL;
+ HideNotificationView();
jennyz 2013/02/14 23:26:45 Why do you need to HideNotificationView twice?
stevenjb 2013/02/14 23:32:25 Oops, didn't see that we already did that. Fixed.
detailed_ = new SmsDetailedView(this);
return detailed_;
}
views::View* TraySms::CreateNotificationView(user::LoginStatus status) {
CHECK(notification_ == NULL);
+ if (detailed_)
+ return NULL;
size_t index;
std::string number, text;
if (GetLatestMessage(&index, &number, &text))
« no previous file with comments | « no previous file | ash/system/tray/system_tray.cc » ('j') | chrome/browser/ui/ash/chrome_shell_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698