Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 12260035: Fix typo in AudioStreamIndicator causing hangs (Closed)

Created:
7 years, 10 months ago by justinlin
Modified:
7 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix typo in AudioStreamIndicator from r182364 causing hangs. NOTRY=true TBR=sky,bauerb Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/media/audio_stream_indicator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
justinlin
7 years, 10 months ago (2013-02-14 06:07:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/12260035/1
7 years, 10 months ago (2013-02-14 06:09:22 UTC) #2
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 10 months ago (2013-02-14 06:11:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/12260035/1
7 years, 10 months ago (2013-02-14 06:14:37 UTC) #4
commit-bot: I haz the power
Change committed as 182401
7 years, 10 months ago (2013-02-14 06:17:25 UTC) #5
Bernhard Bauer
LGTM, thanks!
7 years, 10 months ago (2013-02-14 07:09:44 UTC) #6
miu
On 2013/02/14 07:09:44, Bernhard Bauer wrote: > LGTM, thanks! So, will this need to be ...
7 years, 10 months ago (2013-02-14 20:15:10 UTC) #7
Bernhard Bauer
On 2013/02/14 20:15:10, Yuri wrote: > On 2013/02/14 07:09:44, Bernhard Bauer wrote: > > LGTM, ...
7 years, 10 months ago (2013-02-15 10:09:42 UTC) #8
Bernhard Bauer
On 2013/02/14 20:15:10, Yuri wrote: > On 2013/02/14 07:09:44, Bernhard Bauer wrote: > > LGTM, ...
7 years, 10 months ago (2013-02-15 14:48:27 UTC) #9
justinlin
It actually was merged into something: https://codereview.chromium.org/12207180/ I thought that was M26, but seems seems ...
7 years, 10 months ago (2013-02-15 17:55:01 UTC) #10
Bernhard Bauer
On 2013/02/15 17:55:01, justinlin wrote: > It actually was merged into something: > https://codereview.chromium.org/12207180/ > ...
7 years, 10 months ago (2013-02-18 10:48:35 UTC) #11
anagy4698
7 years, 10 months ago (2013-02-18 14:54:24 UTC) #12
Yes, I think 1412 was used for a canary version.:::(issue 12260035" "


2013/2/18 <bauerb@chromium.org>

> On 2013/02/15 17:55:01, justinlin wrote:
>
>> It actually was merged into something:
>>
https://codereview.chromium.**org/12207180/<https://codereview.chromium.org/1...
>>
>
>  I thought that was M26, but seems seems it's just a release branch:
>>
>
> https://src.chromium.org/**viewvc/chrome/branches/1412/**
> src/chrome/browser/media/**audio_stream_indicator.cc?**
>
view=log&pathrev=182502<https://src.chromium.org/viewvc/chrome/branches/1412/src/chrome/browser/media/audio_stream_indicator.cc?view=log&pathrev=182502>
>
> Yes, I think 1412 was used for a canary version.
>
>
https://chromiumcodereview.**appspot.com/12260035/<https://chromiumcodereview...
>



-- 
anagy4698@gmail.com.

Powered by Google App Engine
This is Rietveld 408576698