Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 12260033: cc: Limit the total number of uploads. (Closed)

Created:
7 years, 10 months ago by epenner
Modified:
7 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

cc: Limit the total number of uploads. We can't reference-count shared memory regions in the GPU process, so we dup/map the memory block for each upload. This doesn't scale for small uploads, both because we can use too many file descriptors, and use too much address space when the small upload transfer buffers are contained in larger shared memory blocks. This limits the total number of uploads to prevent the problem, but this should be fixed properly and this limit removed. BUG=176002 NOTRY=True Since it's a CC only change and unit tests have passed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182400

Patch Set 1 #

Patch Set 2 : Add bug link. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M cc/tile_manager.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
epenner
Ptal. I was working on a fix which keeps track of all memory we have ...
7 years, 10 months ago (2013-02-14 02:46:07 UTC) #1
klobag.chromium
lgtm
7 years, 10 months ago (2013-02-14 04:07:10 UTC) #2
nduca
lgtm
7 years, 10 months ago (2013-02-14 04:31:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/12260033/4002
7 years, 10 months ago (2013-02-14 04:38:44 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=111628
7 years, 10 months ago (2013-02-14 06:11:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/12260033/4002
7 years, 10 months ago (2013-02-14 06:14:29 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 06:17:11 UTC) #7
Message was sent while issue was closed.
Change committed as 182400

Powered by Google App Engine
This is Rietveld 408576698