Issue 12260030: [cc-frame-viewer] Panoply of fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12260030: [cc-frame-viewer] Panoply of fixes (Closed)

Created:
7 years, 10 months ago by nduca

Modified:
7 years, 10 months ago

Reviewers:
ccameron (do not use)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cc-frame-viewer] Panoply of fixes Print good error when parse fails Use world bounds to set up tree quad viewers so you see all the tiles as they fall offscreen. Dont fail if the file has real JSON for frame data, instead of JSON-inside-a-string Put number of inactive tiles at the top of the screen TBR=ccameron NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182447

Patch Set 1 #

Patch Set 2 : more fixes #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -10 lines)			Patch
M	tools/cc-frame-viewer/app/viewer.js	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	tools/cc-frame-viewer/src/lthi_view.js	View		4 chunks	+9 lines, -8 lines	0 comments	Download
M	tools/cc-frame-viewer/src/model.js	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	tools/cc-frame-viewer/src/quad_view_viewport.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12260030/2002

7 years, 10 months ago (2013-02-14 12:27:31 UTC) #2

Message was sent while issue was closed.

Change committed as 182447

Expand Messages | Collapse Messages