Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 12260029: chromeos: Don't override suspend-on-lid-closed. (Closed)

Created:
7 years, 10 months ago by Daniel Erat
Modified:
7 years, 10 months ago
Reviewers:
rkc
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, derat+watch_chromium.org
Visibility:
Public.

Description

chromeos: Don't override suspend-on-lid-closed. This prevents PowerStateOverride::BLOCK_SYSTEM_SUSPEND, which is used while the system is uploading or downloading files or playing web audio, from setting the power manager's disable_lid_suspend override. This override used to be unimplemented in powerd, but it works now, and we don't want the system to stay awake after the lid is closed. It also renames PowerManagerClient::DISABLE_IDLE_LID_SUSPEND to DISABLE_LID_SUSPEND; it doesn't have anything to do with idleness. BUG=176078 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182707

Patch Set 1 #

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M chromeos/dbus/power_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/power_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/power/power_state_override.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/power/power_state_override.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/power/power_state_override_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Erat
7 years, 10 months ago (2013-02-14 01:08:23 UTC) #1
rkc
lgtm
7 years, 10 months ago (2013-02-14 23:18:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/12260029/4001
7 years, 10 months ago (2013-02-14 23:21:12 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=11178
7 years, 10 months ago (2013-02-15 14:03:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/12260029/4001
7 years, 10 months ago (2013-02-15 14:23:21 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-15 14:24:32 UTC) #6
Message was sent while issue was closed.
Change committed as 182707

Powered by Google App Engine
This is Rietveld 408576698